From: Guenter Roeck <linux@roeck-us.net>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: "Armin Wolf" <W_Armin@gmx.de>,
"Zoltán Kővágó" <dirty.ice.hu@gmail.com>,
linux-hwmon@vger.kernel.org
Subject: Re: PROBLEM: NCT6775: suspend doesn't work after updating to Linux 5.19
Date: Wed, 10 Aug 2022 17:20:42 -0700 [thread overview]
Message-ID: <20220811002042.GA1558125@roeck-us.net> (raw)
In-Reply-To: <YvQ3iMpRjEkvZ/Av@hatter.bewilderbeest.net>
On Wed, Aug 10, 2022 at 03:56:08PM -0700, Zev Weiss wrote:
> >
> > I thought about calling it in probe, but I don't really like it because
> > it would slow down boot.
>
> True, that's a fair point.
>
> > Let's introduce a namespace (say, NCT6775) instead.
> > Change all EXPORT_SYMBOL_GPL(x) to EXPORT_SYMBOL_NS_GPL(x, NCT6775) and
> > add MODULE_IMPORT_NS(NCT6775) to nct6775-platform.c and nct6775-i2c.c.
> > This will ensure that the exported symbols can only be called from the
> > nct6775 code.
> >
>
> nct6775-core.c currently has DEFAULT_SYMBOL_NAMESPACE #defined to
> HWMON_NCT6775 (and the platform and i2c drivers are using
> MODULE_IMPORT_NS(HWMON_NCT6775)), so I think that's already in place -- I
> guess we can just leave it as is with the patch that's now upstream then.
>
Excellent, looks like we are all set.
Thanks,
Guenter
next prev parent reply other threads:[~2022-08-11 0:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f5990ef1-4efe-d2b1-8e50-c6890526c054@gmail.com>
2022-08-09 20:56 ` PROBLEM: NCT6775: suspend doesn't work after updating to Linux 5.19 Zev Weiss
2022-08-09 21:28 ` Zoltán Kővágó
2022-08-09 22:34 ` Zev Weiss
2022-08-09 23:50 ` Zoltán Kővágó
2022-08-10 1:39 ` Zev Weiss
2022-08-10 3:00 ` Armin Wolf
2022-08-10 3:36 ` Guenter Roeck
2022-08-10 6:03 ` Zev Weiss
2022-08-10 7:33 ` Guenter Roeck
2022-08-10 22:56 ` Zev Weiss
2022-08-11 0:20 ` Guenter Roeck [this message]
2022-08-10 8:22 ` Zoltán Kővágó
2022-08-10 22:59 ` Zev Weiss
2022-08-10 0:03 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811002042.GA1558125@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=dirty.ice.hu@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox