From: Guenter Roeck <linux@roeck-us.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Duke Du <dukedu83@gmail.com>,
jdelvare@suse.com, corbet@lwn.net, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
fran.hsu@quantatw.com, charles.hsu@quantatw.com,
george.hung@quantatw.com, duke.du@quantatw.com
Subject: Re: [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter.
Date: Wed, 17 Aug 2022 05:47:48 -0700 [thread overview]
Message-ID: <20220817124748.GA397124@roeck-us.net> (raw)
In-Reply-To: <e9b97ea3-0867-d09f-ca59-362931073c9c@gmail.com>
On Wed, Aug 17, 2022 at 07:28:47PM +0700, Bagas Sanjaya wrote:
> On 8/17/22 13:41, Duke Du wrote:
> > make the PMBUS_VOUT_MODE return value 0x17,
> > VOUT returned value is linear11.
> >
> > V2: Correct the tps546d24.rst format.
> >
> > v1: Initial patchset.
> >
>
> Seems like the patch description is just the changelog, which
> should have been put between the dashes and diffstat. I would
> like to see the proper description.
>
Same here. The description doesn't mean anything, should
be a comment in the code, and, yes, the change log should
not be part of the description but follow after '---'.
Guenter
next prev parent reply other threads:[~2022-08-17 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 6:41 [PATCH v2] hwmon: Add the pmbus driver for the TEXAS TPS546D24 Buck Converter Duke Du
2022-08-17 12:28 ` Bagas Sanjaya
2022-08-17 12:47 ` Guenter Roeck [this message]
2022-08-17 12:53 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817124748.GA397124@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bagasdotme@gmail.com \
--cc=charles.hsu@quantatw.com \
--cc=corbet@lwn.net \
--cc=duke.du@quantatw.com \
--cc=dukedu83@gmail.com \
--cc=fran.hsu@quantatw.com \
--cc=george.hung@quantatw.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox