From: Guenter Roeck <linux@roeck-us.net>
To: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v4 2/2] docs: hwmon: add max31760 documentation
Date: Tue, 30 Aug 2022 06:19:02 -0700 [thread overview]
Message-ID: <20220830131902.GA227799@roeck-us.net> (raw)
In-Reply-To: <20220823093417.348-3-Ibrahim.Tilki@analog.com>
On Tue, Aug 23, 2022 at 12:34:17PM +0300, Ibrahim Tilki wrote:
> Adding documentation for max31760 fan speed controller
>
> Signed-off-by: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
Checkpatch reports:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
From Documentation/hwmon/submitting-patches.rst:
* Please run your patch through 'checkpatch --strict'. There should be no
errors, no warnings, and few if any check messages. If there are any
messages, please be prepared to explain.
Guenter
> ---
> Documentation/hwmon/max31760.rst | 65 ++++++++++++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/hwmon/max31760.rst
>
> diff --git a/Documentation/hwmon/max31760.rst b/Documentation/hwmon/max31760.rst
> new file mode 100644
> index 000000000..067b3a5ce
> --- /dev/null
> +++ b/Documentation/hwmon/max31760.rst
> @@ -0,0 +1,65 @@
> +Kernel driver max31760
> +======================
> +
> +Supported chips:
> + * Analog Devices MAX31760
> +
> + Prefix: 'max31760'
> +
> + Addresses scanned: none
> +
> + Datasheet: https://datasheets.maximintegrated.com/en/ds/MAX31760.pdf
> +
> +
> +Author: Ibrahim Tilki <Ibrahim.Tilki@analog.com>
> +
> +Description
> +-----------
> +
> +MAX31760 is a precision fan speed controller with nonvolatile lookup table.
> +Device has one internal and one external temperature sensor support.
> +Controls two fans and measures their speeds.
> +Generates hardware alerts when programmable max and critical temperatures are exceeded.
> +Supports direct and temperature based automatic fan control.
> +
> +Temperature measurement range: from -55°C to 125°C
> +
> +Temperature Resolution: 11 Bits, ±0.125°C
> +
> +Please refer how to instantiate this driver: Documentation/i2c/instantiating-devices.rst
> +
> +Lookup table for auto fan control
> +---------------------------------
> +
> +========= =================================
> +LUT Index Name
> +========= =================================
> +1 PWM value for T < +18°C
> +2 PWM value for +18°C ≤ T < +20°C
> +3 PWM value for +20°C ≤ T < +22°C
> +... ...
> +47 PWM value for +108°C ≤ T < +110°C
> +48 PWM value for T ≥ +110°C
> +========= =================================
> +
> +Sysfs entries
> +-------------
> +
> +=============================== =================================================================================
> +fan[1-2]_input Fan speed (in RPM)
> +fan[1-2]_enable Enable fan readings and fan fault alarms
> +fan[1-2]_fault Fan fault status
> +temp[1-2]_label "Remote" and "Local" temperature channel labels
> +temp[1-2]_input Temperature sensor readings (in millidegrees Celsius)
> +temp1_fault Remote temperature sensor fault status
> +temp[1-2]_max Temperature max value. Asserts "ALERT" pin when exceeded
> +temp[1-2]_max_alarm Temperature max alarm status
> +temp[1-2]_crit Temperature critical value. Asserts "SHDN" pin when exceeded
> +temp[1-2]_crit_alarm Temperature critical alarm status
> +pwm1 PWM value for direct fan control
> +pwm1_enable 1: direct fan control, 2: temperature based auto fan control
> +pwm1_freq PWM frequency in hertz
> +pwm1_auto_channels_temp Temperature source for auto fan control. 1: temp1, 2: temp2, 3: max(temp1, temp2)
> +pwm1_auto_point[1-48]_pwm PWM value for LUT point
> +pwm1_auto_point_temp_hyst Temperature hysteresis for auto fan control. Can be either 2000mC or 4000mC
> +=============================== =================================================================================
prev parent reply other threads:[~2022-08-30 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 9:34 [PATCH v4 0/2] drivers: hwmon: Add max31760 fan speed controller Ibrahim Tilki
2022-08-23 9:34 ` [PATCH v4 1/2] drivers: hwmon: Add max31760 fan speed controller driver Ibrahim Tilki
2022-08-30 13:17 ` Guenter Roeck
2022-08-23 9:34 ` [PATCH v4 2/2] docs: hwmon: add max31760 documentation Ibrahim Tilki
2022-08-30 13:19 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220830131902.GA227799@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Ibrahim.Tilki@analog.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox