From: Guenter Roeck <linux@roeck-us.net>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: linux-hwmon@vger.kernel.org, robert.marko@sartura.hr,
luka.perkov@sartura.hr, jdelvare@suse.com, dev@aboehler.at,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] hwmon: (tps23861) reduce count of i2c transactions for port_status
Date: Thu, 8 Sep 2022 11:49:30 -0700 [thread overview]
Message-ID: <20220908184930.GA3173818@roeck-us.net> (raw)
In-Reply-To: <20220907015405.16547-1-mr.nuke.me@gmail.com>
On Tue, Sep 06, 2022 at 08:54:04PM -0500, Alexandru Gagniuc wrote:
> When reading the 'port_status' debugfs entry, some I2C registers were
> read more than once. This looks inefficient in an I2C trace.
>
> To reduce I2C traffic, update tps23861_port_status_show() to only read
> each register once. Indexing the port number from 0 instead of 1 also
> allows simplifying things a bit.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Applied to hwmon-next.
Thanks,
Guenter
prev parent reply other threads:[~2022-09-08 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 1:54 [PATCH v2 2/3] hwmon: (tps23861) reduce count of i2c transactions for port_status Alexandru Gagniuc
2022-09-07 1:54 ` [PATCH v2 3/3] hwmon: (tps23861) create unique debugfs directory per device Alexandru Gagniuc
2022-09-08 18:49 ` Guenter Roeck
2022-09-08 18:49 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220908184930.GA3173818@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dev@aboehler.at \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=mr.nuke.me@gmail.com \
--cc=robert.marko@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox