From: Guenter Roeck <linux@roeck-us.net>
To: Mengda Chen <chenmengda2009@163.com>
Cc: tharvey@gateworks.com, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, windhl@126.com
Subject: Re: [PATCH v3] hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API
Date: Mon, 19 Sep 2022 06:16:28 -0700 [thread overview]
Message-ID: <20220919131628.GA3546693@roeck-us.net> (raw)
In-Reply-To: <20220916154708.3084515-1-chenmengda2009@163.com>
On Fri, Sep 16, 2022 at 11:47:08PM +0800, Mengda Chen wrote:
> From: Liang He <windhl@126.com>
>
> In gsc_hwmon_get_devtree_pdata(), we should call of_node_get() before
> the of_find_compatible_node() which will automatically call
> of_node_put() for the 'from' argument.
>
> Fixes: 3bce5377ef66 ("hwmon: Add Gateworks System Controller support")
> Signed-off-by: Liang He <windhl@126.com>
> Co-developed-by: Mengda Chen <chenmengda2009@163.com>
> Signed-off-by: Mengda Chen <chenmengda2009@163.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2022-09-19 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 15:47 [PATCH v3] hwmon: (gsc-hwmon) Call of_node_get() before of_find_xxx API Mengda Chen
2022-09-19 13:16 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919131628.GA3546693@roeck-us.net \
--to=linux@roeck-us.net \
--cc=chenmengda2009@163.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=tharvey@gateworks.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox