From: Guenter Roeck <linux@roeck-us.net>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: "Jean Delvare" <jdelvare@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org,
"Markus Niebel" <Markus.Niebel@ew.tq-group.com>
Subject: Re: [PATCH v5 5/5] hwmon: pwm-fan: Switch regulator dynamically
Date: Tue, 20 Sep 2022 07:20:25 -0700 [thread overview]
Message-ID: <20220920142025.GA3718760@roeck-us.net> (raw)
In-Reply-To: <20220914153137.613982-6-alexander.stein@ew.tq-group.com>
On Wed, Sep 14, 2022 at 05:31:37PM +0200, Alexander Stein wrote:
> This adds the enable attribute which is used to select if zero PWM duty
> means to switch off regulator and PWM or to keep them enabled but
> at inactive PWM output level.
> Depending on the select enable mode, turn off the regulator and PWM if
> the PWM duty is zero, or keep them enabled.
> This is especially important for fan using inverted PWM signal polarity.
> Having regulator supplied and PWM disabled, some PWM controllers provide
> the active, rather than inactive signal.
>
> With this change the shutdown as well as suspend/resume paths require
> modifcations as well.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied to hwmon-next.
Thanks,
Guenter
prev parent reply other threads:[~2022-09-20 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 15:31 [PATCH v5 0/5] hwmon: pwm-fan: switch regulator dynamically Alexander Stein
2022-09-14 15:31 ` [PATCH v5 1/5] hwmon: pwm-fan: Refactor fan power on/off Alexander Stein
2022-09-20 14:15 ` Guenter Roeck
2022-09-14 15:31 ` [PATCH v5 2/5] hwmon: pwm-fan: Simplify enable/disable check Alexander Stein
2022-09-20 14:17 ` Guenter Roeck
2022-09-14 15:31 ` [PATCH v5 3/5] hwmon: pwm-fan: Add dedicated power switch function Alexander Stein
2022-09-20 14:18 ` Guenter Roeck
2022-09-14 15:31 ` [PATCH v5 4/5] hwmon: pwm-fan: split __set_pwm into locked/unlocked functions Alexander Stein
2022-09-20 14:19 ` Guenter Roeck
2022-09-14 15:31 ` [PATCH v5 5/5] hwmon: pwm-fan: Switch regulator dynamically Alexander Stein
2022-09-20 14:20 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920142025.GA3718760@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox