From: Guenter Roeck <linux@roeck-us.net>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] hwmon: via686a: Introduce a #define for the driver name and use it
Date: Sat, 24 Sep 2022 07:34:05 -0700 [thread overview]
Message-ID: <20220924143405.GA2299744@roeck-us.net> (raw)
In-Reply-To: <20220924135738.234051-1-u.kleine-koenig@pengutronix.de>
On Sat, Sep 24, 2022 at 03:57:37PM +0200, Uwe Kleine-König wrote:
> Make use of the cpp symbol DRIVER_NAME to set the driver's name and use
> it instead of all explicit usages of the same string. Also make use of
> it instead of sis5595_driver.driver.name which breaks a cyclic dependency
> between sis5595_probe() and sis5595_driver that in the next commit allows
> to drop some forward declarations. For an amd64 allyesconfig this even
> reduces the size of the driver by 3 bytes.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2022-09-24 14:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 13:57 [PATCH 1/2] hwmon: via686a: Introduce a #define for the driver name and use it Uwe Kleine-König
2022-09-24 13:57 ` [PATCH 2/2] hwmon: sis5595: Reorder symbols to get rid of a few forward declarations Uwe Kleine-König
2022-09-24 14:37 ` Guenter Roeck
2022-09-24 15:05 ` Uwe Kleine-König
2022-09-24 14:34 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220924143405.GA2299744@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox