Re: [PATCH -next] hwmon: (nct6683) remove unused variable in nct6683_create_attr_group

[Guenter Roeck <linux@roeck-us.net>]

On Tue, Sep 27, 2022 at 07:43:52PM +0800, Zeng Heng wrote:
> When enable 'unused-but-set-variable' compile
> warning option, it would raise warning as below:
> 
> drivers/hwmon/nct6683.c:415:9:
> warning: variable 'j' set but not used [-Wunused-but-set-variable]
> 
> Variable 'j' in nct6683_create_attr_group is unused,
> so remove it and simplify the 'for' loop.
> 
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/nct6683.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index 6a9f420e7d32..a872f783e9cc 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -412,7 +412,7 @@ nct6683_create_attr_group(struct device *dev,
>  	struct sensor_device_attr_u *su;
>  	struct attribute_group *group;
>  	struct attribute **attrs;
> -	int i, j, count;
> +	int i, count;
>  
>  	if (repeat <= 0)
>  		return ERR_PTR(-EINVAL);
> @@ -443,7 +443,7 @@ nct6683_create_attr_group(struct device *dev,
>  
>  	for (i = 0; i < repeat; i++) {
>  		t = tg->templates;
> -		for (j = 0; *t != NULL; j++) {
> +		while (*t) {
>  			snprintf(su->name, sizeof(su->name),
>  				 (*t)->dev_attr.attr.name, tg->base + i);
>  			if ((*t)->s2) {