Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
	Eddie James <eajames@linux.ibm.com>,
	Joel Stanley <joel@jms.id.au>
Subject: Re: [PATCH] hwmon/occ: OCC sensors aren't arch-specific
Date: Mon, 24 Oct 2022 04:32:18 -0700	[thread overview]
Message-ID: <20221024113218.GA3800308@roeck-us.net> (raw)
In-Reply-To: <20221024081527.3842565-1-jk@codeconstruct.com.au>

On Mon, Oct 24, 2022 at 04:15:27PM +0800, Jeremy Kerr wrote:
> Commit c112d75840fb ("hwmon: OCC drivers are ARM-only") made the OCC
> sensor drivers not selectable on powerpc64:
> 
>   These drivers are for a BMC inside PowerPC servers. The BMC runs on
>   ARM hardware, so only propose the drivers on this architecture, unless
>   build-testing.
> 
> ... but we now have a powerpc64 BMC (still for a powerpc64 host), so
> drop the `depends on` that excludes building for this platform.
> 
> Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>

Should the original patch be reverted instead, and should the revert
be backported ? In other words, is this a bug fix which needs to be
applied to v6.1, or is it needed for v6.2+ only ?

Thanks,
Guenter

> ---
>  drivers/hwmon/occ/Kconfig | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/hwmon/occ/Kconfig b/drivers/hwmon/occ/Kconfig
> index 35a7070db827..348c21100a37 100644
> --- a/drivers/hwmon/occ/Kconfig
> +++ b/drivers/hwmon/occ/Kconfig
> @@ -6,7 +6,6 @@
>  config SENSORS_OCC_P8_I2C
>  	tristate "POWER8 OCC through I2C"
>  	depends on I2C
> -	depends on ARM || ARM64 || COMPILE_TEST
>  	select SENSORS_OCC
>  	help
>  	 This option enables support for monitoring sensors provided by the
> @@ -21,7 +20,6 @@ config SENSORS_OCC_P8_I2C
>  config SENSORS_OCC_P9_SBE
>  	tristate "POWER9 OCC through SBE"
>  	depends on FSI_OCC
> -	depends on ARM || ARM64 || COMPILE_TEST
>  	select SENSORS_OCC
>  	help
>  	 This option enables support for monitoring sensors provided by the

  reply	other threads:[~2022-10-24 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24  8:15 [PATCH] hwmon/occ: OCC sensors aren't arch-specific Jeremy Kerr
2022-10-24 11:32 ` Guenter Roeck [this message]
2022-10-24 12:51   ` Jeremy Kerr
2022-10-25  3:07     ` Joel Stanley
2022-10-26 15:01 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221024113218.GA3800308@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=eajames@linux.ibm.com \
    --cc=jdelvare@suse.com \
    --cc=jk@codeconstruct.com.au \
    --cc=joel@jms.id.au \
    --cc=linux-hwmon@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox