From: Xingjiang Qiao <nanpuyue@gmail.com>
To: Michael Shych <michaelsh@nvidia.com>, Guenter Roeck <linux@roeck-us.net>
Cc: Jean Delvare <jdelvare@suse.com>,
Xingjiang Qiao <nanpuyue@gmail.com>,
linux-hwmon@vger.kernel.org
Subject: RE: [PATCH 2/2] hwmon: (emc2305) fix pwm never being able to set lower
Date: Tue, 6 Dec 2022 13:30:29 +0800 [thread overview]
Message-ID: <20221206053029.169506-1-nanpuyue@gmail.com> (raw)
In-Reply-To: <20221205173611.145571-2-nanpuyue@gmail.com>
The value range of the chip's 'FAN DRIVE SETTING' register is 0-255.
But currently, the driver can only set up to 10 values at most (even via
the 'hwmon' subsystem) when the 'thermal' subsystem is reachable, and
there is no way to increase this limit via "emc2305_platform_data".
Should the "pdata->max_state > EMC2305_FAN_MAX_STATE" check be removed?
Or 'EMC2305_FAN_MAX_STATE' should be defined as '0xff'?
This should be the third patch?
> pdata = dev_get_platdata(&client->dev);
> if (pdata) {
> if (!pdata->max_state || pdata->max_state > EMC2305_FAN_MAX_STATE)
> return -EINVAL;
> data->max_state = pdata->max_state;
next prev parent reply other threads:[~2022-12-06 5:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 17:36 [PATCH 1/2] hwmon: (emc2305) fix unable to probe emc2301/2/3/4 Xingjiang Qiao
2022-12-05 17:36 ` [PATCH 2/2] hwmon: (emc2305) fix pwm never being able to set lower Xingjiang Qiao
2022-12-05 18:27 ` Michael Shych
2022-12-05 19:28 ` Xingjiang Qiao
2022-12-05 18:27 ` Guenter Roeck
2022-12-06 5:30 ` Xingjiang Qiao [this message]
2022-12-05 18:15 ` [PATCH 1/2] hwmon: (emc2305) fix unable to probe emc2301/2/3/4 Guenter Roeck
2022-12-05 18:40 ` Michael Shych
2022-12-05 19:00 ` [PATCH v2 " Xingjiang Qiao
2022-12-06 5:53 ` [PATCH v3 1/2] hwmon: (emc2305) fix unable to probe emc2301/2/3 Xingjiang Qiao
2022-12-06 7:03 ` Guenter Roeck
2022-12-06 12:01 ` Xingjiang Qiao
2022-12-06 22:39 ` Guenter Roeck
2022-12-06 5:53 ` [PATCH v3 2/2] hwmon: (emc2305) fix pwm never being able to set lower Xingjiang Qiao
2022-12-06 22:46 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206053029.169506-1-nanpuyue@gmail.com \
--to=nanpuyue@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michaelsh@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox