From: Guenter Roeck <linux@roeck-us.net>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] hwmon: Fix some kernel-doc comments
Date: Thu, 29 Dec 2022 06:48:48 -0800 [thread overview]
Message-ID: <20221229144848.GA21999@roeck-us.net> (raw)
In-Reply-To: <20221223081056.88345-1-yang.lee@linux.alibaba.com>
On Fri, Dec 23, 2022 at 04:10:56PM +0800, Yang Li wrote:
> Make the description of @aht10_data to @data in aht10_read_values()
> and remove @client in aht10_init() to clear the below warnings:
>
> drivers/hwmon/aht10.c:87: warning: Excess function parameter 'client' description in 'aht10_init'
> drivers/hwmon/aht10.c:131: warning: Function parameter or member 'data' not described in 'aht10_read_values'
> drivers/hwmon/aht10.c:131: warning: Excess function parameter 'aht10_data' description in 'aht10_read_values'
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3543
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
This onlyt affects a single driver, which should be mentioned in the
subject. No need to resend - I'll fix it up -
but please keep it in mind for future patches.
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/aht10.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/aht10.c b/drivers/hwmon/aht10.c
> index d76f3441ecf1..9babd69d54a3 100644
> --- a/drivers/hwmon/aht10.c
> +++ b/drivers/hwmon/aht10.c
> @@ -79,7 +79,6 @@ struct aht10_data {
>
> /**
> * aht10_init() - Initialize an AHT10 chip
> - * @client: the i2c client associated with the AHT10
> * @data: the data associated with this AHT10 chip
> * Return: 0 if succesfull, 1 if not
> */
> @@ -124,7 +123,7 @@ static int aht10_polltime_expired(struct aht10_data *data)
>
> /**
> * aht10_read_values() - read and parse the raw data from the AHT10
> - * @aht10_data: the struct aht10_data to use for the lock
> + * @data: the struct aht10_data to use for the lock
> * Return: 0 if succesfull, 1 if not
> */
> static int aht10_read_values(struct aht10_data *data)
next prev parent reply other threads:[~2022-12-29 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 8:10 [PATCH -next] hwmon: Fix some kernel-doc comments Yang Li
2022-12-29 14:48 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-10 5:53 Yang Li
2023-11-11 3:06 ` Randy Dunlap
2023-11-14 13:43 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229144848.GA21999@roeck-us.net \
--to=linux@roeck-us.net \
--cc=abaci@linux.alibaba.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox