public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: Denis Pauk <pauk.denis@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Renaud Lepage <root@cybikbase.com>, linux-hwmon@vger.kernel.org
Subject: Re: hwmon patch
Date: Wed, 26 Apr 2023 23:27:30 +0300	[thread overview]
Message-ID: <20230426232730.638fd30c@gmail.com> (raw)
In-Reply-To: <638be9f0-4258-4418-834d-4f8123fefa26@roeck-us.net>

Hi,

On Wed, 26 Apr 2023 11:50:46 -0700
Guenter Roeck <linux@roeck-us.net> wrote:

> On Wed, Apr 26, 2023 at 04:38:53PM +0000, Renaud Lepage wrote:
> > Hello! Sorry for reaching out at random.
> >   
> 
> In the future, please use the linux-hwmon@vger.kernel.org mailing list
> to reach out.
> 
> > nct6775-platform.c lists support for a NUMBER of motherboards, of which
> > mine isn't listed. Is there any specific reason why the Strix B360-*,
> > H370-* and Z390-* are listed, but the Z370-* are (conspicuously) not
> > present? 
> 
> Presumably because no one submitted a patch adding support for it,
> or maybe because it doesn't work. Denis, any comments / feedback ?
> 
I suppose that such boards does not have an implementation of required WMI
method or dumps that I have does not provide such methods. I have used UEFI
capsules and dumps from linux hardware database. 
Sometime version provided on ASUS support site can't be unpacked by
uefi-firmware-parser or does not have WMI method required for sensor support. 
Or linux hardware database does not have dumps for such boards. 

As result - script can't detect that such board has support of WMI method
for sure.

Currently, I have information about 19 boards based on such chipset, where
sensor region defined in unknown way or partially for two boards:
* ROG STRIX Z370-H GAMING
* ROG MAXIMUS X HERO.
Other bios dumps for boards or can't be downloaded or can't be unpacked.

So mostly its question when someone test code on a real board
or DSDT dumps will uploaded to https://github.com/linuxhw/ACPI or
https://bugzilla.kernel.org/show_bug.cgi?id=204807 with known region
definitions and WMI methods.
 
Boards could have a different way of define region for sensor or a
different WMI method for access to sensor in the theory. Or a sensor could be
accessed without ACPI conflicts that sometime happens for different board
revision.

Look to https://github.com/asus-wmi-boards-sensors/asus-board-dsdt for more
information.

> On a side note, please never use all-capitals for words.
> That is equivalent to shouting.
> 
> Thanks,
> Guenter
> 
> > If it's lack of testing, I volunteer as tribute. I'm running a
> > https://www.amazon.com/gp/product/B075RHWCBT/ right now.
> > 
Could you please add your board dump as an issue to github or to
https://bugzilla.kernel.org/show_bug.cgi?id=204807 by `acpidump -b`? 
If you can build kernel, could you please build kernel with additional "ROG
STRIX Z370-G GAMING" line to `asus_wmi_boards` list?

> > --
> > Renaud Lepage
> > BScA Informatique et Génie Logiciel
> > BAsc CompSci & Software Eng
> >   

I hope it will help. Thank you!

Best regards,
                  Denis.

      reply	other threads:[~2023-04-26 20:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <SJ0PR12MB5673DC1F156198075B347F90BF659@SJ0PR12MB5673.namprd12.prod.outlook.com>
2023-04-26 18:50 ` hwmon patch Guenter Roeck
2023-04-26 20:27   ` Denis Pauk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230426232730.638fd30c@gmail.com \
    --to=pauk.denis@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=root@cybikbase.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox