Re: hwmon patch

Re: hwmon patch

[Guenter Roeck]

On Wed, Apr 26, 2023 at 04:38:53PM +0000, Renaud Lepage wrote:
> Hello! Sorry for reaching out at random.
> 

In the future, please use the linux-hwmon@vger.kernel.org mailing list
to reach out.

> nct6775-platform.c lists support for a NUMBER of motherboards, of which mine isn't listed. Is there any specific reason why the Strix B360-*, H370-* and Z390-* are listed, but the Z370-* are (conspicuously) not present?
> 

Presumably because no one submitted a patch adding support for it,
or maybe because it doesn't work. Denis, any comments / feedback ?

On a side note, please never use all-capitals for words.
That is equivalent to shouting.

Thanks,
Guenter

> If it's lack of testing, I volunteer as tribute. I'm running a https://www.amazon.com/gp/product/B075RHWCBT/ right now.
> 
> --
> Renaud Lepage
> BScA Informatique et Génie Logiciel
> BAsc CompSci & Software Eng
> 

Re: hwmon patch

[Denis Pauk]

Hi,

On Wed, 26 Apr 2023 11:50:46 -0700
Guenter Roeck <linux@roeck-us.net> wrote:

> On Wed, Apr 26, 2023 at 04:38:53PM +0000, Renaud Lepage wrote:
> > Hello! Sorry for reaching out at random.
> >   
> 
> In the future, please use the linux-hwmon@vger.kernel.org mailing list
> to reach out.
> 
> > nct6775-platform.c lists support for a NUMBER of motherboards, of which
> > mine isn't listed. Is there any specific reason why the Strix B360-*,
> > H370-* and Z390-* are listed, but the Z370-* are (conspicuously) not
> > present? 
> 
> Presumably because no one submitted a patch adding support for it,
> or maybe because it doesn't work. Denis, any comments / feedback ?
> 
I suppose that such boards does not have an implementation of required WMI
method or dumps that I have does not provide such methods. I have used UEFI
capsules and dumps from linux hardware database. 
Sometime version provided on ASUS support site can't be unpacked by
uefi-firmware-parser or does not have WMI method required for sensor support. 
Or linux hardware database does not have dumps for such boards. 

As result - script can't detect that such board has support of WMI method
for sure.

Currently, I have information about 19 boards based on such chipset, where
sensor region defined in unknown way or partially for two boards:
* ROG STRIX Z370-H GAMING
* ROG MAXIMUS X HERO.
Other bios dumps for boards or can't be downloaded or can't be unpacked.

So mostly its question when someone test code on a real board
or DSDT dumps will uploaded to https://github.com/linuxhw/ACPI or
https://bugzilla.kernel.org/show_bug.cgi?id=204807 with known region
definitions and WMI methods.
 
Boards could have a different way of define region for sensor or a
different WMI method for access to sensor in the theory. Or a sensor could be
accessed without ACPI conflicts that sometime happens for different board
revision.

Look to https://github.com/asus-wmi-boards-sensors/asus-board-dsdt for more
information.

> On a side note, please never use all-capitals for words.
> That is equivalent to shouting.
> 
> Thanks,
> Guenter
> 
> > If it's lack of testing, I volunteer as tribute. I'm running a
> > https://www.amazon.com/gp/product/B075RHWCBT/ right now.
> > 
Could you please add your board dump as an issue to github or to
https://bugzilla.kernel.org/show_bug.cgi?id=204807 by `acpidump -b`? 
If you can build kernel, could you please build kernel with additional "ROG
STRIX Z370-G GAMING" line to `asus_wmi_boards` list?

> > --
> > Renaud Lepage
> > BScA Informatique et Génie Logiciel
> > BAsc CompSci & Software Eng
> >   

I hope it will help. Thank you!

Best regards,
                  Denis.