Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Ian Nartowicz <ian@nartowicz.co.uk>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Ian Nartowicz <deadbeef@nartowicz.co.uk>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	Armin Wolf <W_Armin@gmx.de>
Subject: Re: sch5627 on Fujitsu Celsius W280
Date: Wed, 25 Oct 2023 19:22:39 +0100	[thread overview]
Message-ID: <20231025192239.3c5389ae@debian.org> (raw)
In-Reply-To: <9c099de7-4290-5699-122b-927e39577439@roeck-us.net>

On Tue, 24 Oct 2023 07:48:50 -0700
Guenter Roeck <linux@roeck-us.net> wrote:

>On 10/24/23 07:04, Ian Nartowicz wrote:
>> I just upgraded a Celsius W280 to the 6.1 kernel and noticed that hardware
>> monitoring was gone.  Was working in 5.10.  When I added it to the
>> dmi_override_table, it started working again (with a slightly different
>> device name).  dmidecode shows it as an on board device, type other, status
>> disabled (just the watchdog?), and description "SMsC SuperI/O".
>>   
>
>Weird, this is the second private e-mail I get in a single day.
>Is there some information out there suggesting that kernel maintainers
>should be contacted without copying the mailing list ? If so, tell them
>it is wrong. As warning to everyone, I won't reply any further
>to private e-mails like this.
>
>Looking at the code, try adding ignore_dmi=1 as module parameter when
>loading the driver. I think commit 393935baa45e5c messed it up and
>prevents the driver from loading if the parameter is not provided.
>Maybe the conditions in sch56xx_init() are wrong or too generic.
>Armin, any comments ? Do we need to revert your patch ?
>
>Guenter
>

Apologies for the spam.  I didn't know about the mailing list.  Hopefully this
will be more correct.

I tried the ignore_dmi option.  Used manually on sch56xx-common, I was then
able to modprobe sch5627 and it started working.  Slightly clumsy, loading
sch5627 first wouldn't work. It all worked more smoothly with the modules built
in to the kernel and the option on the command line.

I have no idea how many machines use this chip, but I can't imagine the current
list is comprehensive.  Quite old, though?  Let me know if you need more data
or testing on a relevant machine.

--ian

      parent reply	other threads:[~2023-10-25 18:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231024150438.68dd079b@debian.org>
2023-10-24 14:48 ` sch5627 on Fujitsu Celsius W280 Guenter Roeck
2023-10-24 17:42   ` Armin Wolf
2023-10-24 18:21     ` Guenter Roeck
2023-10-25  2:21       ` Armin Wolf
2023-10-25 18:22   ` Ian Nartowicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231025192239.3c5389ae@debian.org \
    --to=ian@nartowicz.co.uk \
    --cc=W_Armin@gmx.de \
    --cc=deadbeef@nartowicz.co.uk \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox