From: Conor Dooley <conor@kernel.org>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com,
Conor Dooley <conor+dt@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Cameron <jic23@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: Increase max number of io-channels
Date: Fri, 1 Dec 2023 16:07:56 +0000 [thread overview]
Message-ID: <20231201-spousal-outage-c8c5ec1fca80@spud> (raw)
In-Reply-To: <074cb071-2a3d-4c9b-89ba-d215a3624b6b@amd.com>
[-- Attachment #1: Type: text/plain, Size: 992 bytes --]
On Fri, Dec 01, 2023 at 09:35:27AM +0100, Michal Simek wrote:
>
>
> On 11/30/23 15:58, Conor Dooley wrote:
> > On Thu, Nov 30, 2023 at 09:46:54AM +0100, Michal Simek wrote:
> > > arch/arm64/boot/dts/xilinx/zynqmp-sm-k26-revA.dts is defining 30 channels
> > > that's why increase it.
> > > But AMS binding defines 51 channels
> > > Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> > > that's why increase number to 51.
> >
> > Please write commit messages for bindings in terms of how they relate to
> > some hardware. In this case I think it would be sufficient to say that
> > the Analog Monitoring system has 51 channels, the opening sentence about
> > the dts as justification provides no actionable information.
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> v2 sent.
I wasn't requesting a v2 FWIW. "$file uses 30 channels" rather than
rephrasing it in terms of the hardware actually having 51 channels just
annoyed me, that's all.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-01 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 8:46 [PATCH] dt-bindings: hwmon: Increase max number of io-channels Michal Simek
2023-11-30 14:58 ` Conor Dooley
2023-12-01 8:35 ` Michal Simek
2023-12-01 16:07 ` Conor Dooley [this message]
2023-12-04 7:57 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231201-spousal-outage-c8c5ec1fca80@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=jdelvare@suse.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox