From: Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org>
To: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: [PATCH v3 0/2] Add support for LTC4282
Date: Tue, 05 Dec 2023 16:22:54 +0100 [thread overview]
Message-ID: <20231205-ltc4282-support-v3-0-e0877b281bc2@analog.com> (raw)
v1:
* https://lore.kernel.org/linux-hwmon/20231110151905.1659873-1-nuno.sa@analog.com/
v2:
* https://lore.kernel.org/linux-hwmon/20231124-ltc4282-support-v2-0-952bf926f83c@analog.com
Changes in V3:
- Bindings:
* Remove 'default' from string types;
* Update gpios descriptions and removed leftovers from when they were
integer types.
* Dropped gpio function. With that, adi,gpio3-mode and adi,gpio-alert were
dropped.
- Driver:
* Make all clock ops static;
* Dropped macro to create debugfs attributes;
* Dropped GPIO support;
* Removed regulator consumer header (leftover from v1).
There are still some possible interfaces which are dubious from an hwmon
point view. Namely:
* fet_short_fault
* fet_bad_fault
* power1_good
power1_good and fet_short can be "monitored" with gpio1 and 2
respectively so maybe we could remove the. OTHO, some users might want
the pins free for GPIO usage. fet_bad_fault is a status bit (we also have it in
fault_logs) that might be meaningful to monitor (I think).
Also to note, I'm still seeing the following sparse issue:
"CHECK drivers/hwmon/ltc4282.c
drivers/hwmon/ltc4282.c:805:34: warning: dubious: x & !y
drivers/hwmon/ltc4282.c:895:34: warning: dubious: x & !y"
However, this does not look to be directly related with the driver. It's
on FIED_PREP() taking values like !val or !!val.
I'm also removing the GPIO maintainers/reviewers from Cc since there's no
gpiochip support anymore. If not adequate, I'll Cc them again...
---
Nuno Sa (2):
dt-bindings: hwmon: Add LTC4282 bindings
hwmon: ltc4282: add support for the LTC4282 chip
.../devicetree/bindings/hwmon/adi,ltc4282.yaml | 142 ++
Documentation/hwmon/index.rst | 1 +
Documentation/hwmon/ltc4282.rst | 108 ++
MAINTAINERS | 8 +
drivers/hwmon/Kconfig | 11 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/ltc4282.c | 1705 ++++++++++++++++++++
7 files changed, 1976 insertions(+)
---
base-commit: 44482310b7f8ac4cd8fa7be4cee8c1b260ea5ee9
change-id: 20231124-ltc4282-support-8c1675e31508
--
Thanks!
- Nuno Sá
next reply other threads:[~2023-12-05 15:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 15:22 Nuno Sa via B4 Relay [this message]
2023-12-05 15:22 ` [PATCH v3 1/2] dt-bindings: hwmon: Add LTC4282 bindings Nuno Sa via B4 Relay
2023-12-05 16:18 ` Conor Dooley
2023-12-06 8:38 ` Nuno Sá
2023-12-06 15:41 ` Conor Dooley
2023-12-05 15:22 ` [PATCH v3 2/2] hwmon: ltc4282: add support for the LTC4282 chip Nuno Sa via B4 Relay
2023-12-11 15:36 ` Guenter Roeck
2023-12-12 14:28 ` Nuno Sá
2023-12-12 15:14 ` Guenter Roeck
2023-12-12 15:30 ` Nuno Sá
2023-12-12 17:59 ` Guenter Roeck
2023-12-13 10:06 ` Nuno Sá
2023-12-13 14:35 ` Guenter Roeck
2023-12-13 14:44 ` Nuno Sá
2023-12-11 15:41 ` Guenter Roeck
2023-12-12 13:53 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205-ltc4282-support-v3-0-e0877b281bc2@analog.com \
--to=devnull+nuno.sa.analog.com@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox