From: Ivor Wanders <ivor@iwanders.net>
To: w_armin@gmx.de
Cc: corbet@lwn.net, hdegoede@redhat.com, ivor@iwanders.net,
jdelvare@suse.com, linux-doc@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux@roeck-us.net, luzmaximilian@gmail.com,
markgross@kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v3 2/2] hwmon: add fan speed monitoring driver for Surface devices
Date: Sat, 27 Jan 2024 15:28:28 -0500 [thread overview]
Message-ID: <20240127202828.11140-1-ivor@iwanders.net> (raw)
In-Reply-To: <34960bb8-fb85-4cca-8b84-d99596d046e4@gmx.de>
Hello Armin, thank you for your second review.
> maybe you can just return 0 here.
Good idea, that's indeed the only option for ret, so that makes it clearer.
> Maybe use PTR_ERR_OR_ZERO() here?
Definitely, thanks for suggesting this; cleans it up nicely.
~Ivor
prev parent reply other threads:[~2024-01-27 20:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 18:33 [PATCH v3 0/2] Surface fan monitoring driver Ivor Wanders
2024-01-13 18:33 ` [PATCH v3 1/2] platform/surface: aggregator_registry: add entry for fan speed Ivor Wanders
2024-01-13 18:33 ` [PATCH v3 2/2] hwmon: add fan speed monitoring driver for Surface devices Ivor Wanders
2024-01-24 18:38 ` Maximilian Luz
2024-01-25 15:19 ` Armin Wolf
2024-01-27 20:28 ` Ivor Wanders [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240127202828.11140-1-ivor@iwanders.net \
--to=ivor@iwanders.net \
--cc=corbet@lwn.net \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luzmaximilian@gmail.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=w_armin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox