From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0049729A9; Mon, 11 Mar 2024 17:34:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710178481; cv=none; b=LMtZ7wLxaGD9uThgp6255xALHp+naFIfGu0vdZqrVWFXMBKvrpLZck8FUO8YcobM2HCapvHIxo6U6dFLDuPtfssYGUBMIodfAQ/p0CBzGYnZv2XqAqaUzjok1ScIcWmJ4DachAtl3jgcIO7trsjM0FpyqDSrE0tlhUvCoReBVik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710178481; c=relaxed/simple; bh=Ej9iokf53c+lmdcFKb97Bh3rX/K4nJN37K+iO8QuNG4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ORbXUe+96nF8y/1k1a+2wOuxFaZb3ZuL3AoQT4IWiSyELr/YDVRbENgYKN3lBFAxFos5O2Na46S8E6VwPxyFcXQiJy770kX9vUaZOaMHd01VtdQLEQo7cGvCySTzoANg57tPSdOYjS5x0OYWxalosUuvjdBiNGC7bZEpMI+XWFA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iP5wdNZR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iP5wdNZR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41292C433C7; Mon, 11 Mar 2024 17:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710178480; bh=Ej9iokf53c+lmdcFKb97Bh3rX/K4nJN37K+iO8QuNG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iP5wdNZRWbyLGV7n0/bjFdODYl8MNg1fI9i4ew9aeafT9munvawc3OOZNIJgUtrXN vJL2ikiWAjyE+xybzKAU+ntk/jAhBvoYfkheLnE38hquKHmVwTLMezI+syNFcbS/pD ZxadFE+//WtrTX8+JmxuVOWIAJ2Faxu34Vn1aKqU05OVZP5DI6Fr6d+aScXF8j7Ouq 8np2tczT7U1CeqTRApaWLSLhMg5hI4jJxotuu0bHmF7aSE9cOvR2sNfNDwtUy4OHt+ g6HxkyYHB/w4NL4PZiu92p42rhVG3aERV4M7IZX5iIxhRgA97eOeTloUpxk3VINiJJ FF5elrXLxbJgg== Date: Mon, 11 Mar 2024 11:34:38 -0600 From: Rob Herring To: Chanh Nguyen Cc: Jean Delvare , Guenter Roeck , Krzysztof Kozlowski , Conor Dooley , Justin Ledford , devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, OpenBMC Maillist , Open Source Submission , Phong Vo , Thang Nguyen , Quan Nguyen Subject: Re: [PATCH 3/3] dt-bindings: hwmon: max31790: Add pwmout-pin-as-tach-input property Message-ID: <20240311173438.GA1451467-robh@kernel.org> References: <20240311111347.23067-1-chanh@os.amperecomputing.com> <20240311111347.23067-4-chanh@os.amperecomputing.com> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240311111347.23067-4-chanh@os.amperecomputing.com> On Mon, Mar 11, 2024 at 06:13:47PM +0700, Chanh Nguyen wrote: > Add pwmout-pin-as-tach-input property. > > Signed-off-by: Chanh Nguyen > --- > Documentation/devicetree/bindings/hwmon/max31790.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/max31790.yaml b/Documentation/devicetree/bindings/hwmon/max31790.yaml > index 5a93e6bdebda..447cac17053a 100644 > --- a/Documentation/devicetree/bindings/hwmon/max31790.yaml > +++ b/Documentation/devicetree/bindings/hwmon/max31790.yaml > @@ -25,6 +25,16 @@ properties: > reg: > maxItems: 1 > > + pwmout-pin-as-tach-input: > + description: | > + An array of six integers responds to six PWM channels for > + configuring the pwm to tach mode. > + When set to 0, the associated PWMOUT produces a PWM waveform for > + control of fan speed. When set to 1, PWMOUT becomes a TACH input > + $ref: /schemas/types.yaml#/definitions/uint8-array > + maxItems: 6 > + minItems: 6 Seems incomplete. For example, fan tachs have different number of pulses per revolution, don't you need to know that too? There's a common fan binding now (or pending). You should use that and this property won't be needed. Rob