Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: Maximilian Luz <luzmaximilian@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Maximilian Luz <luzmaximilian@gmail.com>,
	Jean Delvare <jdelvare@suse.com>,
	linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: [PATCH] hwmon: (surface_fan) Change dependency on SURFACE_AGGREGATOR_BUS to 'select'
Date: Sat, 10 Aug 2024 23:47:08 +0200	[thread overview]
Message-ID: <20240810214709.425095-1-luzmaximilian@gmail.com> (raw)

The SURFACE_AGGREGATOR_BUS option specifies whether SAM bus support is
build into the SAM controller driver or not. The surface_fan module
requires this, due to which it has a dependency on the option.

However, from an end-user perspective, it makes more sense to
automatically enable the option when choosing to include the fan driver,
rather than requiring the user to know that they have to enable bus
support first before they get shown the option for the fan driver.

Therefore change the 'depends on' to 'select'.

Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
 drivers/hwmon/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index b60fe2e58ad6..e4d9a035a57a 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -2069,7 +2069,7 @@ config SENSORS_SFCTEMP
 config SENSORS_SURFACE_FAN
 	tristate "Surface Fan Driver"
 	depends on SURFACE_AGGREGATOR
-	depends on SURFACE_AGGREGATOR_BUS
+	select SURFACE_AGGREGATOR_BUS
 	help
 	  Driver that provides monitoring of the fan on Surface Pro devices that
 	  have a fan, like the Surface Pro 9.
-- 
2.46.0


             reply	other threads:[~2024-08-10 21:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-10 21:47 Maximilian Luz [this message]
2024-08-10 23:20 ` [PATCH] hwmon: (surface_fan) Change dependency on SURFACE_AGGREGATOR_BUS to 'select' Maximilian Luz
2024-08-12  4:44   ` Guenter Roeck
2024-08-13 18:43     ` Maximilian Luz
2024-08-10 23:53 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240810214709.425095-1-luzmaximilian@gmail.com \
    --to=luzmaximilian@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox