From: Ninad Palsule <ninad@linux.ibm.com>
To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
eajames@linux.ibm.com, jdelvare@suse.com, linux@roeck-us.net,
corbet@lwn.net, joel@jms.id.au, andrew@codeconstruct.com.au,
Delphine_CC_Chiu@Wiwynn.com, broonie@kernel.org,
peteryin.openbmc@gmail.com, noahwang.wang@outlook.com,
naresh.solanki@9elements.com, lukas@wunner.de,
jbrunet@baylibre.com, patrick.rudolph@9elements.com,
gregkh@linuxfoundation.org, peterz@infradead.org,
pbiel7@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-i2c@vger.kernel.org
Cc: Ninad Palsule <ninad@linux.ibm.com>
Subject: [PATCH v1 1/4] hwmon: pmbus-core: Add label for fan and temp
Date: Thu, 12 Dec 2024 15:49:00 -0600 [thread overview]
Message-ID: <20241212214927.3586509-2-ninad@linux.ibm.com> (raw)
In-Reply-To: <20241212214927.3586509-1-ninad@linux.ibm.com>
Adding label files for fan and temperature sensors in the power supply.
The openbmc application dbus-sensor(psusensor) requires those files to
consfigure those sensors.
Note that prefix for temp label is temp[A..C] used instead of temp[1..3]
as dbus-sensor(psusensor) application calculate index based on last
digit in the name so we do not want to make index double digit after
appending page index.
Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
---
drivers/hwmon/pmbus/pmbus_core.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index a7000314e5ad..149b3c5f3a4c 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -2144,6 +2144,7 @@ static const struct pmbus_sensor_attr temp_attributes[] = {
{
.reg = PMBUS_READ_TEMPERATURE_1,
.class = PSC_TEMPERATURE,
+ .label = "tempA",
.paged = true,
.update = true,
.compare = true,
@@ -2156,6 +2157,7 @@ static const struct pmbus_sensor_attr temp_attributes[] = {
}, {
.reg = PMBUS_READ_TEMPERATURE_2,
.class = PSC_TEMPERATURE,
+ .label = "tempB",
.paged = true,
.update = true,
.compare = true,
@@ -2168,6 +2170,7 @@ static const struct pmbus_sensor_attr temp_attributes[] = {
}, {
.reg = PMBUS_READ_TEMPERATURE_3,
.class = PSC_TEMPERATURE,
+ .label = "tempC",
.paged = true,
.update = true,
.compare = true,
@@ -2282,6 +2285,17 @@ static int pmbus_add_fan_attributes(struct i2c_client *client,
PSC_FAN, true, true, true) == NULL)
return -ENOMEM;
+ /*
+ * Add fan label.
+ * Assuming paged attributes while passing page index
+ */
+ ret = pmbus_add_label(data, "fan", index, "fan",
+ page + 1, 0xff);
+ if (ret) {
+ dev_err(data->dev, "Fan label add failed ret=%d\n", ret);
+ return ret;
+ }
+
/* Fan control */
if (pmbus_check_word_register(client, page,
pmbus_fan_command_registers[f])) {
--
2.43.0
next prev parent reply other threads:[~2024-12-12 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 21:48 [PATCH v1 0/4] Add support for Intel CRPS PSU Ninad Palsule
2024-12-12 21:49 ` Ninad Palsule [this message]
2024-12-12 22:06 ` [PATCH v1 1/4] hwmon: pmbus-core: Add label for fan and temp Guenter Roeck
2024-12-13 16:12 ` Ninad Palsule
2024-12-13 17:08 ` Guenter Roeck
2024-12-16 17:53 ` Ninad Palsule
2024-12-12 21:49 ` [PATCH v1 2/4] hwmon: (pmbus/crps) Add Intel CRPS185 power supply Ninad Palsule
2024-12-13 1:29 ` Guenter Roeck
2024-12-16 18:01 ` Ninad Palsule
2024-12-12 21:49 ` [PATCH v1 3/4] dt-bindings: hwmon: intel,crps185: Add to trivial Ninad Palsule
2024-12-13 11:08 ` Krzysztof Kozlowski
2024-12-12 21:49 ` [PATCH v1 4/4] ARM: dts: aspeed: system1: Use crps PSU driver Ninad Palsule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241212214927.3586509-2-ninad@linux.ibm.com \
--to=ninad@linux.ibm.com \
--cc=Delphine_CC_Chiu@Wiwynn.com \
--cc=andrew@codeconstruct.com.au \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lukas@wunner.de \
--cc=naresh.solanki@9elements.com \
--cc=noahwang.wang@outlook.com \
--cc=patrick.rudolph@9elements.com \
--cc=pbiel7@gmail.com \
--cc=peteryin.openbmc@gmail.com \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox