Re: [PATCH v1 1/4] hwmon: pmbus-core: Add label for fan and temp

Guenter Roeck
2024-12-13T17:08:34Z

On 12/13/24 08:12, Ninad Palsule wrote:
> Hello Guenter,
>
> On 12/12/24 16:06, Guenter Roeck wrote:
>> On 12/12/24 13:49, Ninad Palsule wrote:
>>> Adding label files for fan and temperature sensors in the power supply.
>>> The openbmc application dbus-sensor(psusensor) requires those files to
>>> consfigure those sensors.
>>> Note that prefix for temp label is temp[A..C] used instead of temp[1..3]
>>> as dbus-sensor(psusensor) application calculate index based on last
>>> digit in the name so we do not want to make index double digit after
>>> appending page index.
>>>
>>> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com>
>>
>> We are not going to fix userspace problems in the kernel.
>>
>> Guenter
>>
>
> Thanks for the quick review.
>
> Sorry I am not clear on this. I feel that it is better to support labels for temperature
>
> sensors and fans like other. Are you saying we should not support these labels or
>
> I need update in the patch to support them better?
>

There should be no such labels. Labels are supposed to have specific meanings,
such as "this is the CPU temperature sensor", not vague meanings such as "tempA".

Guenter