From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>, Xu Liang <lxu@maxlinear.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH net-next 0/4] net: phy: remove calls to devm_hwmon_sanitize_name
Date: Fri, 14 Mar 2025 18:23:48 +0100 [thread overview]
Message-ID: <20250314182348.21ac024e@fedora-2.home> (raw)
In-Reply-To: <198f3cd0-6c39-4783-afe7-95576a4b8539@gmail.com>
Hi Heiner,
On Thu, 13 Mar 2025 20:43:44 +0100
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> Since c909e68f8127 ("hwmon: (core) Use device name as a fallback in
> devm_hwmon_device_register_with_info") we can simply provide NULL
> as name argument.
>
> Heiner Kallweit (4):
> net: phy: realtek: remove call to devm_hwmon_sanitize_name
> net: phy: tja11xx: remove call to devm_hwmon_sanitize_name
> net: phy: mxl-gpy: remove call to devm_hwmon_sanitize_name
> net: phy: marvell-88q2xxx: remove call to devm_hwmon_sanitize_name
>
> drivers/net/phy/marvell-88q2xxx.c | 8 +-------
> drivers/net/phy/mxl-gpy.c | 8 +-------
> drivers/net/phy/nxp-tja11xx.c | 19 +++++--------------
> drivers/net/phy/realtek/realtek_hwmon.c | 7 +------
> 4 files changed, 8 insertions(+), 34 deletions(-)
>
With more coffee in my system, I took a better look and it indeed looks
good to me.
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Sorry about the noisy comments,
Maxime
next prev parent reply other threads:[~2025-03-14 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 19:43 [PATCH net-next 0/4] net: phy: remove calls to devm_hwmon_sanitize_name Heiner Kallweit
2025-03-13 19:44 ` [PATCH net-next 1/4] net: phy: realtek: remove call " Heiner Kallweit
2025-03-13 19:45 ` [PATCH net-next 2/4] net: phy: tja11xx: " Heiner Kallweit
2025-03-14 7:45 ` Maxime Chevallier
2025-03-14 11:26 ` Heiner Kallweit
2025-03-14 11:47 ` Maxime Chevallier
2025-03-13 19:45 ` [PATCH net-next 3/4] net: phy: mxl-gpy: " Heiner Kallweit
2025-03-13 19:46 ` [PATCH net-next 4/4] net: phy: marvell-88q2xxx: " Heiner Kallweit
2025-03-14 17:23 ` Maxime Chevallier [this message]
2025-03-21 17:10 ` [PATCH net-next 0/4] net: phy: remove calls " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314182348.21ac024e@fedora-2.home \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=kuba@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox