From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Soponar <asoponar@taladin.ro>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-iio@vger.kernel.org, linux-leds@vger.kernel.org,
linux-watchdog@vger.kernel.org, jdelvare@suse.com,
linux@roeck-us.net, pavel@ucw.cz, lee@kernel.org,
baocheng.su@siemens.com, wim@linux-watchdog.org,
tobias.schaffner@siemens.com,
angelogioacchino.delregno@collabora.com,
benedikt.niedermayr@siemens.com, matthias.bgg@gmail.com,
aardelean@baylibre.com, contact@sopy.one
Subject: Re: [PATCH 11/16] iio: mcp3564: Fix type incompatibility with non-macro find_closest
Date: Thu, 15 May 2025 18:14:05 +0100 [thread overview]
Message-ID: <20250515181405.083dd030@jic23-huawei> (raw)
In-Reply-To: <20250515081332.151250-12-asoponar@taladin.ro>
On Thu, 15 May 2025 11:13:27 +0300
Alexandru Soponar <asoponar@taladin.ro> wrote:
> The mcp3564_oversampling_avail array was previously declared as unsigned
> int but used with find_closest(). With find_closest() now implemented as
> a function taking signed int parameters instead of a macro, passing
> unsigned arrays causes type incompatibility errors. This patch changes the
> arrays type from unsigned int to int to ensure compatibility with the
> function signature and prevent compilation errors.
>
> Signed-off-by: Alexandru Soponar <asoponar@taladin.ro>
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/iio/adc/mcp3564.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
> index a68f1cd6883e..01efc77f710a 100644
> --- a/drivers/iio/adc/mcp3564.c
> +++ b/drivers/iio/adc/mcp3564.c
> @@ -253,7 +253,7 @@ enum mcp3564_oversampling {
> MCP3564_OVERSAMPLING_RATIO_98304
> };
>
> -static const unsigned int mcp3564_oversampling_avail[] = {
> +static const int mcp3564_oversampling_avail[] = {
> [MCP3564_OVERSAMPLING_RATIO_32] = 32,
> [MCP3564_OVERSAMPLING_RATIO_64] = 64,
> [MCP3564_OVERSAMPLING_RATIO_128] = 128,
next prev parent reply other threads:[~2025-05-15 17:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 8:13 [PATCH 0/16] lib: Refactor find_closest() and find_closest_descending() from macros to lib functions Alexandru Soponar
2025-05-15 8:13 ` [PATCH 01/16] hwmon: w83795: Fix type incompatibility with non-macro find_closest Alexandru Soponar
2025-05-15 8:13 ` [PATCH 02/16] hwmon: emc1403: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 03/16] hwmon: ina3221: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 04/16] hwmon: lm95234: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 05/16] hwmon: max1619: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 06/16] hwmon: lm75: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 07/16] hwmon: ltc4282: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 08/16] hwmon: max6639: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 09/16] hwmon: max20740: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 10/16] iio: ad7606: " Alexandru Soponar
2025-05-15 17:13 ` Jonathan Cameron
2025-05-15 8:13 ` [PATCH 11/16] iio: mcp3564: " Alexandru Soponar
2025-05-15 17:14 ` Jonathan Cameron [this message]
2025-05-19 8:09 ` Marius.Cristea
2025-05-15 8:13 ` [PATCH 12/16] iio: max44009: " Alexandru Soponar
2025-05-15 17:14 ` Jonathan Cameron
2025-05-15 8:13 ` [PATCH 13/16] leds: eds-mt6370-rgb: Fix type incompatibility with find_closest() Alexandru Soponar
2025-05-22 14:33 ` Lee Jones
2025-05-15 8:13 ` [PATCH 14/16] regulator: max77857: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 15/16] watchdog: simatic-ipc-wdt: " Alexandru Soponar
2025-05-15 8:13 ` [PATCH 16/16] lib: move find_closest() and find_closest_descending() to lib functions Alexandru Soponar
2025-05-19 16:35 ` David Lechner
2025-05-19 15:44 ` [PATCH 0/16] lib: Refactor find_closest() and find_closest_descending() from macros " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515181405.083dd030@jic23-huawei \
--to=jic23@kernel.org \
--cc=aardelean@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asoponar@taladin.ro \
--cc=baocheng.su@siemens.com \
--cc=benedikt.niedermayr@siemens.com \
--cc=contact@sopy.one \
--cc=jdelvare@suse.com \
--cc=lee@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=tobias.schaffner@siemens.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox