Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Chiang Brian <chiang.brian@inventec.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Jonathan Corbet <corbet@lwn.net>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>
Cc: oe-kbuild-all@lists.linux.dev,
	Chiang Brian <chiang.brian@inventec.com>,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685
Date: Fri, 13 Jun 2025 02:15:14 +0800	[thread overview]
Message-ID: <202506130217.6OQ8zSf5-lkp@intel.com> (raw)
In-Reply-To: <20250610102556.236300-3-chiang.brian@inventec.com>

Hi Chiang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on groeck-staging/hwmon-next krzk-dt/for-next linus/master v6.16-rc1 next-20250612]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chiang-Brian/hwmon-pmbus-tps53679-Add-support-for-TPS53685/20250610-192612
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20250610102556.236300-3-chiang.brian%40inventec.com
patch subject: [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685
config: s390-randconfig-r073-20250611 (https://download.01.org/0day-ci/archive/20250613/202506130217.6OQ8zSf5-lkp@intel.com/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project f819f46284f2a79790038e1f6649172789734ae8)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506130217.6OQ8zSf5-lkp@intel.com/

smatch warnings:
drivers/hwmon/pmbus/tps53679.c:288 tps53679_probe() warn: inconsistent indenting

vim +288 drivers/hwmon/pmbus/tps53679.c

   249	
   250	static int tps53679_probe(struct i2c_client *client)
   251	{
   252		struct device *dev = &client->dev;
   253		struct pmbus_driver_info *info;
   254		enum chips chip_id;
   255	
   256		if (dev->of_node)
   257			chip_id = (uintptr_t)of_device_get_match_data(dev);
   258		else
   259			chip_id = i2c_match_id(tps53679_id, client)->driver_data;
   260	
   261		info = devm_kmemdup(dev, &tps53679_info, sizeof(*info), GFP_KERNEL);
   262		if (!info)
   263			return -ENOMEM;
   264	
   265		switch (chip_id) {
   266		case tps53647:
   267		case tps53667:
   268			info->pages = TPS53647_PAGE_NUM;
   269			info->identify = tps53679_identify;
   270			break;
   271		case tps53676:
   272			info->identify = tps53676_identify;
   273			break;
   274		case tps53679:
   275		case tps53688:
   276			info->pages = TPS53679_PAGE_NUM;
   277			info->identify = tps53679_identify;
   278			break;
   279		case tps53681:
   280			info->pages = TPS53679_PAGE_NUM;
   281			info->phases[0] = 6;
   282			info->identify = tps53681_identify;
   283			info->read_word_data = tps53681_read_word_data;
   284			break;
   285		case tps53685:
   286		    info->pages = TPS53679_PAGE_NUM;
   287		    info->identify = tps53685_identify;
 > 288			break;
   289		default:
   290			return -ENODEV;
   291		}
   292	
   293		return pmbus_do_probe(client, info);
   294	}
   295	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-06-12 18:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250610102556.236300-1-chiang.brian@inventec.com>
2025-06-10 10:25 ` [PATCH v9 2/2] hwmon: (pmbus/tps53679) Add support for TPS53685 Chiang Brian
2025-06-12 18:15   ` kernel test robot [this message]
2025-06-16 16:15   ` Guenter Roeck
2025-06-17 10:51     ` Brian Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202506130217.6OQ8zSf5-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=chiang.brian@inventec.com \
    --cc=corbet@lwn.net \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox