Re: [PATCH v3] pwm: mc33xs2410: add support for temperature sensors

[Dimitri Fedrau <dima.fedrau@gmail.com>]

Am Tue, Jun 24, 2025 at 09:29:25AM +0200 schrieb Uwe Kleine-König:
> On Tue, Jun 24, 2025 at 09:04:42AM +0200, Dimitri Fedrau wrote:
> > Hi Uwe,
> > 
> > Am Mon, Jun 23, 2025 at 11:07:24AM +0200 schrieb Uwe Kleine-König:
> > > hello Dimitri,
> > > 
> > > On Thu, Jun 19, 2025 at 07:32:42PM +0200, Dimitri Fedrau via B4 Relay wrote:
> > > > @@ -29,6 +30,8 @@
> > > >  
> > > >  #include <linux/spi/spi.h>
> > > >  
> > > > +/* ctrl registers */
> > > > +
> > > >  #define MC33XS2410_GLB_CTRL			0x00
> > > >  #define MC33XS2410_GLB_CTRL_MODE		GENMASK(7, 6)
> > > >  #define MC33XS2410_GLB_CTRL_MODE_NORMAL		FIELD_PREP(MC33XS2410_GLB_CTRL_MODE, 1)
> > > > @@ -51,6 +54,21 @@
> > > >  
> > > >  #define MC33XS2410_WDT				0x14
> > > >  
> > > > +#define MC33XS2410_TEMP_WT			0x29
> > > > +#define MC33XS2410_TEMP_WT_MASK			GENMASK(7, 0)
> > > > +
> > > > +/* diag registers */
> > > > +
> > > > +/* chan in { 1 ... 4 } */
> > > > +#define MC33XS2410_OUT_STA(chan)		(0x02 + (chan) - 1)
> > > > +#define MC33XS2410_OUT_STA_OTW			BIT(8)
> > > > +
> > > > +#define MC33XS2410_TS_TEMP_DIE			0x26
> > > > +#define MC33XS2410_TS_TEMP_MASK			GENMASK(9, 0)
> > > 
> > > Keep the registers in address order please
> >
> > Aren't they ? There are "ctrl" and "diag" registers and I didn't mix up
> > adresses. There is a comment for each of them when defines start.
> 
> +#define MC33XS2410_TEMP_WT                     0x29
> ...
> +#define MC33XS2410_TS_TEMP_DIE                 0x26
>

MC33XS2410_TEMP_WT is a "ctrl" register and MC33XS2410_TS_TEMP_DIE is a
"diag" register. Both register sets start with adress 0. "ctrl" and
"diag" defines are separated because I didn't want to mix them up.

[...]

Best regards,
Dimitri Fedrau