* [PATCH] hwmon: (sch56xx-common) don't print superfluous errors
@ 2025-08-13 19:07 Wolfram Sang
2025-08-27 15:58 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2025-08-13 19:07 UTC (permalink / raw)
To: linux-hwmon; +Cc: Wolfram Sang, Jean Delvare, Guenter Roeck
The watchdog core will handle error messages already.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/hwmon/sch56xx-common.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c
index 71941b1bb573..98e075e54e9d 100644
--- a/drivers/hwmon/sch56xx-common.c
+++ b/drivers/hwmon/sch56xx-common.c
@@ -544,10 +544,8 @@ void sch56xx_watchdog_register(struct device *parent, u16 addr, u32 revision,
watchdog_set_drvdata(&data->wddev, data);
err = devm_watchdog_register_device(parent, &data->wddev);
- if (err) {
- pr_err("Registering watchdog chardev: %d\n", err);
+ if (err)
devm_kfree(parent, data);
- }
}
EXPORT_SYMBOL(sch56xx_watchdog_register);
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (sch56xx-common) don't print superfluous errors
2025-08-13 19:07 [PATCH] hwmon: (sch56xx-common) don't print superfluous errors Wolfram Sang
@ 2025-08-27 15:58 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2025-08-27 15:58 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-hwmon, Jean Delvare
On Wed, Aug 13, 2025 at 09:07:28PM +0200, Wolfram Sang wrote:
> The watchdog core will handle error messages already.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-27 15:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13 19:07 [PATCH] hwmon: (sch56xx-common) don't print superfluous errors Wolfram Sang
2025-08-27 15:58 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).