From: Rob Herring <robh@kernel.org>
To: Flaviu Nistor <flaviu.nistor@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: tmp102: Add TMP110 and TMP113 devices
Date: Mon, 22 Sep 2025 11:20:04 -0500 [thread overview]
Message-ID: <20250922162004.GA199858-robh@kernel.org> (raw)
In-Reply-To: <20250916063342.4436-1-flaviu.nistor@gmail.com>
On Tue, Sep 16, 2025 at 09:33:42AM +0300, Flaviu Nistor wrote:
> On Mon, Sep 15, 2025 at 18:18:51PM +0100, Conor Dooley wrote:
>
> >On Mon, Sep 15, 2025 at 08:08:18PM +0300, Flaviu Nistor wrote:
> >> Add a compatible string for TMP110 and TMP113 devices.
> >>=20
> >> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
> >> ---
> >> Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>=20
> >> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> >> index 96b2e4969f78..840b5306a8cf 100644
> >> --- a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> >> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> >> @@ -13,6 +13,8 @@ properties:
> >> compatible:
> >> enum:
> >> - ti,tmp102
> >> + - ti,tmp110
> >> + - ti,tmp113
> >
> >The driver has no match data and no compatible based decisions added in
> >your patch. Why is a fallback to tmp102 not suitable?
> >
> Thanks for the review, it is now more clear to me. You are right, the
> fallback to tmp102 can be used. My intentions were to be able to make it
> clear in the dts which is the real used sensor on the board but this can
> be achieved via the node name (or label).
No, node name or label is not how you do that. compatible is the right
way.
next prev parent reply other threads:[~2025-09-22 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 17:08 [PATCH 1/2] dt-bindings: hwmon: tmp102: Add TMP110 and TMP113 devices Flaviu Nistor
2025-09-15 17:08 ` [PATCH 2/2] hwmon: tmp102: Add support for " Flaviu Nistor
2025-09-15 17:18 ` [PATCH 1/2] dt-bindings: hwmon: tmp102: Add " Conor Dooley
2025-09-16 6:33 ` Flaviu Nistor
2025-09-22 16:20 ` Rob Herring [this message]
2025-09-24 15:55 ` Guenter Roeck
2025-09-24 18:12 ` Conor Dooley
2025-09-29 17:07 ` Flaviu Nistor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250922162004.GA199858-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=flaviu.nistor@gmail.com \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).