From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Andreas Kemnade <andreas@kemnade.info>,
Guenter Roeck <linux@roeck-us.net>,
Sasha Levin <sashal@kernel.org>,
linux-hwmon@vger.kernel.org
Subject: [PATCH AUTOSEL 6.17-6.1] hwmon: sy7636a: add alias
Date: Thu, 9 Oct 2025 11:56:21 -0400 [thread overview]
Message-ID: <20251009155752.773732-115-sashal@kernel.org> (raw)
In-Reply-To: <20251009155752.773732-1-sashal@kernel.org>
From: Andreas Kemnade <andreas@kemnade.info>
[ Upstream commit 80038a758b7fc0cdb6987532cbbf3f75b13e0826 ]
Add module alias to have it autoloaded.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Link: https://lore.kernel.org/r/20250909080249.30656-1-andreas@kemnade.info
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
YES
**Rationale**
- Adding `MODULE_ALIAS("platform:sy7636a-temperature");` in
`drivers/hwmon/sy7636a-hwmon.c:105` ensures udev can auto-load the
module when the MFD core registers the `sy7636a-temperature` platform
device. Today the driver lacks any `MODULE_ALIAS` or
`MODULE_DEVICE_TABLE`, so built-as-module systems never bind
automatically and the hwmon sensor stays unavailable unless manually
`modprobe`d—an obvious functional bug.
- The platform child is created by `drivers/mfd/simple-mfd-i2c.c:66-73`,
which exposes the `sy7636a-temperature` modalias; the regulator
sibling already has a matching alias via its platform ID table
(`drivers/regulator/sy7636a-regulator.c:122-134`), highlighting that
the hwmon side simply missed the same piece.
- History (`git log -- drivers/hwmon/sy7636a-hwmon.c`) shows the driver
has shipped without an alias since it was introduced in commit
de34a40532507 (Jan 2022), so every stable kernel carrying this driver
is affected.
- The fix is a one-line metadata change with no runtime impact beyond
enabling the intended autoload path, so regression risk is negligible
and it squarely fits stable rules.
**Next Steps**
1. Queue the patch for all supported stable trees that include
`drivers/hwmon/sy7636a-hwmon.c`.
drivers/hwmon/sy7636a-hwmon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/sy7636a-hwmon.c b/drivers/hwmon/sy7636a-hwmon.c
index ed110884786b4..a12fc0ce70e76 100644
--- a/drivers/hwmon/sy7636a-hwmon.c
+++ b/drivers/hwmon/sy7636a-hwmon.c
@@ -104,3 +104,4 @@ module_platform_driver(sy7636a_sensor_driver);
MODULE_DESCRIPTION("SY7636A sensor driver");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:sy7636a-temperature");
--
2.51.0
next prev parent reply other threads:[~2025-10-09 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 15:54 [PATCH AUTOSEL 6.17-6.6] hwmon: (k10temp) Add device ID for Strix Halo Sasha Levin
2025-10-09 15:55 ` [PATCH AUTOSEL 6.17-6.12] hwmon: (dell-smm) Remove Dell Precision 490 custom config data Sasha Levin
2025-10-09 15:55 ` [PATCH AUTOSEL 6.17-5.15] hwmon: (sbtsi_temp) AMD CPU extended temperature range support Sasha Levin
2025-10-09 15:56 ` [PATCH AUTOSEL 6.17-6.6] hwmon: (k10temp) Add thermal support for AMD Family 1Ah-based models Sasha Levin
2025-10-09 15:56 ` [PATCH AUTOSEL 6.17-5.4] hwmon: (dell-smm) Add support for Dell OptiPlex 7040 Sasha Levin
2025-10-09 15:56 ` [PATCH AUTOSEL 6.17-6.12] hwmon: (lenovo-ec-sensors) Update P8 supprt Sasha Levin
2025-10-09 15:56 ` Sasha Levin [this message]
2025-10-09 15:56 ` [PATCH AUTOSEL 6.17-6.1] hwmon: (asus-ec-sensors) increase timeout for locking ACPI mutex Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251009155752.773732-115-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=andreas@kemnade.info \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox