From: Andreas Kemnade <andreas@kemnade.info>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: regulator: Add Fitipower FP9931/JD9930
Date: Mon, 10 Nov 2025 13:28:07 +0100 [thread overview]
Message-ID: <20251110132807.1ceb82b5@kemnade.info> (raw)
In-Reply-To: <83b3dbf4-0916-432b-b46f-bf459ce264f3@kernel.org>
On Mon, 10 Nov 2025 08:30:41 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On 09/11/2025 22:12, Andreas Kemnade wrote:
> >>
> >> You must drop ref. That's the entire point of common unit suffix.
> >>
> > I tried without it:
> >
> > fitipower,tdly-ms:
> > description:
> > Power up soft start delay settings tDLY1-4 bitfields in the
> > POWERON_DELAY register
> > default: <0 0 0 0>
>
> Arrays are in [] (see also some examples of arrays in the example-schema).
> [0, 0, 0, 0]
>
> And then it should work, but does not which I think is bug in dtschema.
> I think it works fine when you drop the "default:" completely, so please
> do so. I'll take a look at the issue.
>
ok, dropping default makes dtschema happy.
> enum should be in one line, btw.
>
> Your patchset has also blank line warnings.
I fixed the ones shown by
checkpatch.pl --strict
are there any more I am missing?
Regards,
Andreas
next prev parent reply other threads:[~2025-11-10 12:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 20:06 [PATCH 0/3] regulator: Add FP9931/JD9930 Andreas Kemnade
2025-11-07 20:06 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Fitipower Andreas Kemnade
2025-11-08 12:10 ` Krzysztof Kozlowski
2025-11-07 20:06 ` [PATCH 2/3] dt-bindings: regulator: Add Fitipower FP9931/JD9930 Andreas Kemnade
2025-11-08 12:17 ` Krzysztof Kozlowski
2025-11-08 14:21 ` Andreas Kemnade
2025-11-08 14:46 ` Krzysztof Kozlowski
2025-11-08 16:52 ` Andreas Kemnade
2025-11-09 17:13 ` Krzysztof Kozlowski
2025-11-09 21:12 ` Andreas Kemnade
2025-11-10 7:30 ` Krzysztof Kozlowski
2025-11-10 12:28 ` Andreas Kemnade [this message]
2025-11-07 20:06 ` [PATCH 3/3] regulator: Add FP9931/JD9930 driver Andreas Kemnade
2025-11-08 12:21 ` Krzysztof Kozlowski
2025-11-08 23:03 ` Andreas Kemnade
2025-11-10 3:31 ` kernel test robot
2025-11-10 11:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110132807.1ceb82b5@kemnade.info \
--to=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).