* [PATCH] hwmon: (max6697) fix regmap leak on probe failure
@ 2025-11-27 13:43 Johan Hovold
2025-11-27 16:08 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Johan Hovold @ 2025-11-27 13:43 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-hwmon, linux-kernel, Johan Hovold, stable
The i2c regmap allocated during probe is never freed.
Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.
Fixes: 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap")
Cc: stable@vger.kernel.org # 6.12
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/hwmon/max6697.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/max6697.c b/drivers/hwmon/max6697.c
index 0735a1d2c20f..6926d787b5ad 100644
--- a/drivers/hwmon/max6697.c
+++ b/drivers/hwmon/max6697.c
@@ -548,7 +548,7 @@ static int max6697_probe(struct i2c_client *client)
struct regmap *regmap;
int err;
- regmap = regmap_init_i2c(client, &max6697_regmap_config);
+ regmap = devm_regmap_init_i2c(client, &max6697_regmap_config);
if (IS_ERR(regmap))
return PTR_ERR(regmap);
--
2.51.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: (max6697) fix regmap leak on probe failure
2025-11-27 13:43 [PATCH] hwmon: (max6697) fix regmap leak on probe failure Johan Hovold
@ 2025-11-27 16:08 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2025-11-27 16:08 UTC (permalink / raw)
To: Johan Hovold; +Cc: linux-hwmon, linux-kernel, stable
On Thu, Nov 27, 2025 at 02:43:51PM +0100, Johan Hovold wrote:
> The i2c regmap allocated during probe is never freed.
>
> Switch to using the device managed allocator so that the regmap is
> released on probe failures (e.g. probe deferral) and on driver unbind.
>
> Fixes: 3a2a8cc3fe24 ("hwmon: (max6697) Convert to use regmap")
> Cc: stable@vger.kernel.org # 6.12
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-27 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-27 13:43 [PATCH] hwmon: (max6697) fix regmap leak on probe failure Johan Hovold
2025-11-27 16:08 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).