Linux Hardware Monitor development
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Gabriel Marcano <gabemarcano@yahoo.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell G5 5505 to fan control whitelist
Date: Mon, 1 Dec 2025 20:08:19 +0100	[thread overview]
Message-ID: <20251201190819.sum3d3b7tixxkzzj@pali> (raw)
In-Reply-To: <20251128191650.6191-1-gabemarcano@yahoo.com>

On Friday 28 November 2025 11:16:44 Gabriel Marcano wrote:
> Allow manual PWM control on Dell G5 5505 (and SE).
> 
> Signed-off-by: Gabriel Marcano <gabemarcano@yahoo.com>

Acked-by: Pali Rohár <pali@kernel.org>

> ---
> I tested this on my Dell G5 5505 SE, although there only seem to be
> three fan speeds regardless of the actual PWM setting (off, somewhere in
> the middle, and max).
> 
>  drivers/hwmon/dell-smm-hwmon.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index cbe1a74a3dee..683baf361c4c 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1533,6 +1533,15 @@ static const struct i8k_fan_control_data i8k_fan_control_data[] __initconst = {
>  };
>  
>  static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> +	{
> +		.ident = "Dell G5 5505",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "G5 5505"),
> +
> +		},
> +		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> +	},
>  	{
>  		.ident = "Dell Latitude 5480",
>  		.matches = {
> 
> base-commit: 765e56e41a5af2d456ddda6cbd617b9d3295ab4e
> -- 
> 2.52.0
> 

      parent reply	other threads:[~2025-12-01 19:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20251128191650.6191-1-gabemarcano.ref@yahoo.com>
2025-11-28 19:16 ` [PATCH] hwmon: (dell-smm) Add Dell G5 5505 to fan control whitelist Gabriel Marcano
2025-11-28 22:11   ` Guenter Roeck
2025-12-01 19:08   ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251201190819.sum3d3b7tixxkzzj@pali \
    --to=pali@kernel.org \
    --cc=gabemarcano@yahoo.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox