From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-i3c@lists.infradead.org
Subject: Re: [PATCH 4/4] i3c: drop i3c_priv_xfer and i3c_device_do_priv_xfers()
Date: Wed, 3 Dec 2025 00:15:26 +0100 [thread overview]
Message-ID: <2025120223152613f1586a@mail.local> (raw)
In-Reply-To: <20251028-lm75-v1-4-9bf88989c49c@nxp.com>
Hello Frank,
You'll have to rebase this patch.
On 28/10/2025 10:57:55-0400, Frank Li wrote:
> Drop i3c_priv_xfer and i3c_device_do_priv_xfers() after all driver switch
> to use new API.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> This patch need be applied after all other patches applied.
> ---
> include/linux/i3c/device.h | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/include/linux/i3c/device.h b/include/linux/i3c/device.h
> index ae0662d9d77eb3fa0c976de1803e9c2ff9547451..47e6c95d87f9494d48c5b0463544916f26923501 100644
> --- a/include/linux/i3c/device.h
> +++ b/include/linux/i3c/device.h
> @@ -25,7 +25,7 @@
> * @I3C_ERROR_M2: M2 error
> *
> * These are the standard error codes as defined by the I3C specification.
> - * When -EIO is returned by the i3c_device_do_priv_xfers() or
> + * When -EIO is returned by the i3c_device_do_i3c_xfers() or
> * i3c_device_send_hdr_cmds() one can check the error code in
> * &struct_i3c_xfer.err or &struct i3c_hdr_cmd.err to get a better idea of
> * what went wrong.
> @@ -79,9 +79,6 @@ struct i3c_xfer {
> enum i3c_error_code err;
> };
>
> -/* keep back compatible */
> -#define i3c_priv_xfer i3c_xfer
> -
> /**
> * enum i3c_dcr - I3C DCR values
> * @I3C_DCR_GENERIC_DEVICE: generic I3C device
> @@ -311,13 +308,6 @@ static __always_inline void i3c_i2c_driver_unregister(struct i3c_driver *i3cdrv,
> int i3c_device_do_xfers(struct i3c_device *dev, struct i3c_xfer *xfers,
> int nxfers, enum i3c_xfer_mode mode);
>
> -static inline int i3c_device_do_priv_xfers(struct i3c_device *dev,
> - struct i3c_xfer *xfers,
> - int nxfers)
> -{
> - return i3c_device_do_xfers(dev, xfers, nxfers, I3C_SDR);
> -}
> -
> int i3c_device_do_setdasa(struct i3c_device *dev);
>
> void i3c_device_get_info(const struct i3c_device *dev, struct i3c_device_info *info);
>
> --
> 2.34.1
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-12-02 23:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-28 14:57 [PATCH 0/4] i3c: switch to use switch to use i3c_xfer from i3c_priv_xfer Frank Li
2025-10-28 14:57 ` [PATCH 1/4] hwmon: (lm75): " Frank Li
2025-10-29 15:57 ` Guenter Roeck
2025-10-28 14:57 ` [PATCH 2/4] net: mctp i3c: " Frank Li
2025-10-30 4:13 ` Matt Johnston
2025-10-28 14:57 ` [PATCH 3/4] regmap: " Frank Li
2025-10-28 15:10 ` Mark Brown
2025-10-28 14:57 ` [PATCH 4/4] i3c: drop i3c_priv_xfer and i3c_device_do_priv_xfers() Frank Li
2025-12-02 23:15 ` Alexandre Belloni [this message]
2025-12-02 17:06 ` [PATCH 0/4] i3c: switch to use switch to use i3c_xfer from i3c_priv_xfer Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025120223152613f1586a@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).