Re: [PATCH] [v3, apply after -rc1] i3c: simplify combined i3c/i2c dependencies

Arnd Bergmann
2026-02-06T08:22:06Z

On Thu, Feb 5, 2026, at 21:11, Jonathan Cameron wrote:
> On Wed, 4 Feb 2026 10:15:56 -0800 Guenter Roeck <linux@roeck-us.net> wrote:
>> On 2/4/26 08:41, Arnd Bergmann wrote:
>> > From: Arnd Bergmann <arnd@arndb.de>
>> >
>> > All combined i2c/i3c drivers appear to suffer from the same link
>> > time problem when CONFIG_I3C is set to 'm':
>> >
>> > arm-linux-gnueabi-ld: drivers/iio/magnetometer/mmc5633.o: in function `mmc5633_i3c_driver_init':
>> > mmc5633.c:(.init.text+0x30): undefined reference to `i3c_driver_register_with_owner'
>> >
>> > This was previously fixed every time by marking individual
>> > drivers as 'depends on I2C; depends on I3C || !I3C', but this gets
>> > tedious and is somewhat confusing.
>> >
>> > Add a Kconfig symbol 'I3C_OR_I2C' to help replace those dependencies,
>> > and use this in all the existing drivers that had already fixed it
>> > as well as the new mmc5633 driver.
>> >
>> > Fixes: 6e5f6bf2e3f0 ("iio: magnetometer: Add mmc5633 sensor")
>
> I think can drop the Fixes tag now given there is a fix in between for
> the original issue.

Right, my mistake.

Arnd