From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: "Armin Wolf" <W_Armin@gmx.de>, "Pali Rohár" <pali@kernel.org>,
"Guenter Roeck" <linux@roeck-us.net>,
"Sasha Levin" <sashal@kernel.org>,
linux-hwmon@vger.kernel.org
Subject: [PATCH AUTOSEL 6.19-6.12] hwmon: (dell-smm) Add support for Dell OptiPlex 7080
Date: Fri, 13 Feb 2026 20:00:03 -0500 [thread overview]
Message-ID: <20260214010245.3671907-123-sashal@kernel.org> (raw)
In-Reply-To: <20260214010245.3671907-1-sashal@kernel.org>
From: Armin Wolf <W_Armin@gmx.de>
[ Upstream commit 46c3e87a79179454f741f797c274dd25f5c6125e ]
The Dell OptiPlex 7080 supports the legacy SMM interface for reading
sensors and performing fan control. Whitelist this machine so that
this driver loads automatically.
Closes: https://github.com/Wer-Wolf/i8kutils/issues/16
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Acked-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20260104000654.6406-1-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
LLM Generated explanations, may be completely bogus:
## Analysis
### Commit Message Analysis
This commit adds a DMI whitelist entry for the Dell OptiPlex 7080 to the
`dell-smm-hwmon` driver. The commit message explains that this machine
supports the legacy SMM interface for reading sensors and performing fan
control, and the whitelist entry enables the driver to load
automatically on this hardware.
There's a linked issue (`https://github.com/Wer-
Wolf/i8kutils/issues/16`) showing a real user request for this support.
### Code Change Analysis
The change is a simple addition of a single DMI matching entry to the
`i8k_dmi_table[]` array:
```c
{
.ident = "Dell OptiPlex 7080",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7080"),
},
},
```
This is structurally identical to the existing entries for OptiPlex
7060, 7050, and 7040. The pattern uses `DMI_EXACT_MATCH` for the product
name (matching the convention of other OptiPlex entries), preventing
false matches with similarly named models.
### Classification
This falls squarely into the **device ID / hardware quirk / whitelist**
exception category. It's adding a machine identifier to an existing
driver's whitelist table so the driver auto-loads on that hardware.
Without this entry, the Dell OptiPlex 7080 doesn't get hardware
monitoring and fan control support from this driver (unless force-
loaded).
### Scope and Risk Assessment
- **Lines changed**: +7 lines (a single DMI table entry)
- **Files touched**: 1 (`drivers/hwmon/dell-smm-hwmon.c`)
- **Risk**: Extremely low. The entry only affects Dell OptiPlex 7080
machines. It cannot affect any other hardware. The matching pattern is
well-established and identical in structure to dozens of other entries
in the same table.
- **Complexity**: Trivial
### User Impact
Users with Dell OptiPlex 7080 machines running stable kernels would
benefit from having hardware monitoring and fan control work
automatically. This is a desktop PC used in corporate
environments—exactly the kind of hardware that runs stable/LTS kernels.
### Stability Indicators
- **Acked-by**: Pali Rohár (co-maintainer of this driver)
- **Signed-off-by**: Guenter Roeck (hwmon maintainer)
- The existing driver framework is mature and well-tested
- The same pattern is used for many other Dell models already in the
table
### Dependency Check
No dependencies. The driver and DMI matching infrastructure exist in all
relevant stable trees. This is a self-contained addition to a data
table.
### Conclusion
This is a textbook example of a hardware whitelist addition that is
appropriate for stable backporting. It enables existing, well-tested
driver functionality on a specific hardware platform. The change is
trivial, zero-risk to other systems, reviewed by the subsystem
maintainers, and benefits real users running stable kernels on Dell
OptiPlex 7080 desktops.
**YES**
drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index 93143cfc157cf..038edffc1ac74 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1325,6 +1325,13 @@ static const struct dmi_system_id i8k_dmi_table[] __initconst = {
DMI_MATCH(DMI_PRODUCT_NAME, "MP061"),
},
},
+ {
+ .ident = "Dell OptiPlex 7080",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7080"),
+ },
+ },
{
.ident = "Dell OptiPlex 7060",
.matches = {
--
2.51.0
prev parent reply other threads:[~2026-02-14 1:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260214010245.3671907-1-sashal@kernel.org>
2026-02-14 0:58 ` [PATCH AUTOSEL 6.19] hwmon: (asus-ec-sensors) add Pro WS TRX50-SAGE WIFI A Sasha Levin
2026-02-14 0:58 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (nct6683) Add customer ID for ASRock Z590 Taichi Sasha Levin
2026-02-14 0:59 ` [PATCH AUTOSEL 6.19-6.1] hwmon: (f71882fg) Add F81968 support Sasha Levin
2026-02-14 0:59 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (emc2305) Fix a resource leak in emc2305_of_parse_pwm_child Sasha Levin
2026-02-14 0:59 ` [PATCH AUTOSEL 6.19-6.6] hwmon: (nct6775) Add ASUS Pro WS WRX90E-SAGE SE Sasha Levin
2026-02-14 0:59 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (nct7363) Fix a resource leak in nct7363_present_pwm_fanin Sasha Levin
2026-02-14 1:00 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260214010245.3671907-123-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=W_Armin@gmx.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pali@kernel.org \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox