public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Robert McIntyre <rjmcinty@hotmail.com>,
	Eugene Shalygin <eugene.shalygin@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Sasha Levin <sashal@kernel.org>,
	linux-hwmon@vger.kernel.org
Subject: [PATCH AUTOSEL 6.19] hwmon: (asus-ec-sensors) add Pro WS TRX50-SAGE WIFI A
Date: Fri, 13 Feb 2026 19:58:31 -0500	[thread overview]
Message-ID: <20260214010245.3671907-31-sashal@kernel.org> (raw)
In-Reply-To: <20260214010245.3671907-1-sashal@kernel.org>

From: Robert McIntyre <rjmcinty@hotmail.com>

[ Upstream commit af7e57d444141ac9e77b57296d59c3e965c4c4fa ]

Adding support for Pro WS TRX50-SAGE WIFI A, which is identical
sensors-wise to Pro WS TRX50-SAGE WIFI

Signed-off-by: Robert McIntyre <rjmcinty@hotmail.com>
Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
Link: https://lore.kernel.org/r/20251213200531.259435-4-eugene.shalygin@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

## Analysis

### Commit Message Analysis
This commit adds support for a new motherboard variant — the "Pro WS
TRX50-SAGE WIFI A" — to the asus-ec-sensors hwmon driver. The commit
message explicitly states that this board is "identical sensors-wise" to
the already-supported "Pro WS TRX50-SAGE WIFI".

### Code Change Analysis
The change is minimal and purely additive:

1. **Documentation**: Adds one line to `asus_ec_sensors.rst` listing the
   new board name in the supported boards list.

2. **Driver**: Adds two lines to the DMI matching table in `asus-ec-
   sensors.c`:
  ```c
  DMI_EXACT_MATCH_ASUS_BOARD_NAME("Pro WS TRX50-SAGE WIFI A",
  &board_info_pro_ws_trx50_sage_wifi),
  ```
  This reuses the **exact same** `board_info_pro_ws_trx50_sage_wifi`
  structure as the existing "Pro WS TRX50-SAGE WIFI" entry. No new
  board_info structure, no new sensor definitions, no new code paths —
  just a new DMI string mapping to an existing configuration.

### Classification: New Device ID / Board ID
This falls squarely into the **"New Device IDs"** exception category for
stable backports. It is analogous to adding a new PCI ID or USB ID to an
existing driver. The driver already exists and supports this hardware
configuration; only the board name string is different.

### Risk Assessment
- **Risk: Extremely low**. The change adds a DMI match entry that points
  to an already-tested board configuration. If the DMI doesn't match
  (user has a different board), this code is never reached. If it does
  match, it uses the same well-tested sensor configuration.
- **Scope**: 3 lines of actual code change (1 doc line + 2 driver
  lines).
- **Dependencies**: None. The `board_info_pro_ws_trx50_sage_wifi`
  structure and the `DMI_EXACT_MATCH_ASUS_BOARD_NAME` macro already
  exist in stable trees.
- **Regression potential**: Essentially zero — this cannot affect any
  existing board's behavior.

### User Impact
Without this patch, users with the "Pro WS TRX50-SAGE WIFI A"
motherboard variant have no hardware monitoring sensor support through
this driver, even though the hardware is identical to the already-
supported model. This is a real-world hardware enablement issue.

### Stable Criteria Check
- **Obviously correct**: Yes — trivial DMI table addition reusing
  existing config.
- **Fixes a real issue**: Yes — enables hardware monitoring on a board
  variant that should work but doesn't.
- **Small and contained**: Yes — 3 lines.
- **No new features**: Correct — this uses existing driver
  functionality; it just adds a new board name to match against.
- **No new APIs**: Correct.

**YES**

 Documentation/hwmon/asus_ec_sensors.rst | 1 +
 drivers/hwmon/asus-ec-sensors.c         | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/Documentation/hwmon/asus_ec_sensors.rst b/Documentation/hwmon/asus_ec_sensors.rst
index 232885f24430d..b5e1bc7ac0643 100644
--- a/Documentation/hwmon/asus_ec_sensors.rst
+++ b/Documentation/hwmon/asus_ec_sensors.rst
@@ -10,6 +10,7 @@ Supported boards:
  * PRIME X670E-PRO WIFI
  * PRIME Z270-A
  * Pro WS TRX50-SAGE WIFI
+ * Pro WS TRX50-SAGE WIFI A
  * Pro WS X570-ACE
  * Pro WS WRX90E-SAGE SE
  * ProArt X570-CREATOR WIFI
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 61b18b88ee8ff..a1445799e23d8 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -793,6 +793,8 @@ static const struct dmi_system_id dmi_table[] = {
 					&board_info_pro_art_x870E_creator_wifi),
 	DMI_EXACT_MATCH_ASUS_BOARD_NAME("Pro WS TRX50-SAGE WIFI",
 					&board_info_pro_ws_trx50_sage_wifi),
+	DMI_EXACT_MATCH_ASUS_BOARD_NAME("Pro WS TRX50-SAGE WIFI A",
+					&board_info_pro_ws_trx50_sage_wifi),
 	DMI_EXACT_MATCH_ASUS_BOARD_NAME("Pro WS WRX90E-SAGE SE",
 					&board_info_pro_ws_wrx90e_sage_se),
 	DMI_EXACT_MATCH_ASUS_BOARD_NAME("Pro WS X570-ACE",
-- 
2.51.0


       reply	other threads:[~2026-02-14  1:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260214010245.3671907-1-sashal@kernel.org>
2026-02-14  0:58 ` Sasha Levin [this message]
2026-02-14  0:58 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (nct6683) Add customer ID for ASRock Z590 Taichi Sasha Levin
2026-02-14  0:59 ` [PATCH AUTOSEL 6.19-6.1] hwmon: (f71882fg) Add F81968 support Sasha Levin
2026-02-14  0:59 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (emc2305) Fix a resource leak in emc2305_of_parse_pwm_child Sasha Levin
2026-02-14  0:59 ` [PATCH AUTOSEL 6.19-6.6] hwmon: (nct6775) Add ASUS Pro WS WRX90E-SAGE SE Sasha Levin
2026-02-14  0:59 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (nct7363) Fix a resource leak in nct7363_present_pwm_fanin Sasha Levin
2026-02-14  1:00 ` [PATCH AUTOSEL 6.19-6.12] hwmon: (dell-smm) Add support for Dell OptiPlex 7080 Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260214010245.3671907-31-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=eugene.shalygin@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=patches@lists.linux.dev \
    --cc=rjmcinty@hotmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox