public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: patches@lists.linux.dev, stable@vger.kernel.org
Cc: Denis Pauk <pauk.denis@gmail.com>, Marcus <shoes2ga@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Sasha Levin <sashal@kernel.org>,
	linux-hwmon@vger.kernel.org
Subject: [PATCH AUTOSEL 6.19-6.6] hwmon: (nct6775) Add ASUS Pro WS WRX90E-SAGE SE
Date: Fri, 13 Feb 2026 19:59:36 -0500	[thread overview]
Message-ID: <20260214010245.3671907-96-sashal@kernel.org> (raw)
In-Reply-To: <20260214010245.3671907-1-sashal@kernel.org>

From: Denis Pauk <pauk.denis@gmail.com>

[ Upstream commit 246167b17c14e8a5142368ac6457e81622055e0a ]

Boards Pro WS WRX90E-SAGE SE has got a nct6775 chip, but by default there's
no use of it because of resource conflict with WMI method.

Add the board to the WMI monitoring list.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=204807
Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
Tested-by: Marcus <shoes2ga@gmail.com>
Link: https://lore.kernel.org/r/20251231155316.2048-1-pauk.denis@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

LLM Generated explanations, may be completely bogus:

## Analysis

### Commit Message Analysis
This commit adds a board identifier string ("Pro WS WRX90E-SAGE SE") to
the `asus_msi_boards[]` list in the nct6775 hwmon driver. The commit
message explains that this ASUS motherboard has an nct6775 hardware
monitoring chip, but it cannot be used by default due to a resource
conflict with WMI methods. Adding the board to the WMI monitoring list
resolves this conflict and enables hardware monitoring.

### Code Change Analysis
The change is a **single line addition** — inserting one string into an
alphabetically sorted list of board names:

```c
"Pro WS WRX90E-SAGE SE",
```

This is inserted between "Pro WS W790E-SAGE SE" and "ProArt
B650-CREATOR", maintaining alphabetical order. No logic changes, no new
functions, no structural modifications.

### Classification: Hardware Quirk / Device ID Addition
This falls squarely into the **"hardware quirks/workarounds"** exception
category for stable backports. The `asus_msi_boards[]` list is
effectively a board-level quirk table that tells the driver to use WMI-
based monitoring instead of direct I/O, resolving the resource conflict.
Without this entry, users of this specific motherboard cannot use
hardware monitoring at all.

### Stability Indicators
- **Tested-by:** Marcus confirmed the fix works on the actual hardware
- **Bug report link:**
  https://bugzilla.kernel.org/show_bug.cgi?id=204807 — this is a
  documented real-world issue
- **Reviewed and merged by:** Guenter Roeck, the hwmon subsystem
  maintainer
- **Pattern:** Identical to dozens of other board additions in this same
  file that have been backported to stable

### Risk Assessment
- **Risk: Extremely low.** Adding a string to a board match list cannot
  affect any other board or any other code path. The match is exact —
  only the "Pro WS WRX90E-SAGE SE" board is affected.
- **Scope:** Single line in a single file
- **Dependencies:** None — the WMI monitoring infrastructure already
  exists in stable trees
- **Regression potential:** Essentially zero

### User Impact
Without this fix, users of the ASUS Pro WS WRX90E-SAGE SE motherboard (a
workstation-class board) have no hardware monitoring capability. This is
a real user-reported bug (kernel bugzilla #204807) with a tested fix.

### Stable Criteria Check
1. **Obviously correct and tested:** Yes — single string addition,
   tested by user
2. **Fixes a real bug:** Yes — hardware monitoring doesn't work without
   it
3. **Important issue:** Yes — complete loss of hwmon functionality for
   this board
4. **Small and contained:** Yes — one line
5. **No new features:** Correct — enables existing functionality on
   specific hardware
6. **Applies cleanly:** Very likely — it's a simple list insertion

**YES**

 drivers/hwmon/nct6775-platform.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/hwmon/nct6775-platform.c b/drivers/hwmon/nct6775-platform.c
index c3a719aef1ace..555029dfe713f 100644
--- a/drivers/hwmon/nct6775-platform.c
+++ b/drivers/hwmon/nct6775-platform.c
@@ -1357,6 +1357,7 @@ static const char * const asus_msi_boards[] = {
 	"Pro WS W680-ACE IPMI",
 	"Pro WS W790-ACE",
 	"Pro WS W790E-SAGE SE",
+	"Pro WS WRX90E-SAGE SE",
 	"ProArt B650-CREATOR",
 	"ProArt B660-CREATOR D4",
 	"ProArt B760-CREATOR D4",
-- 
2.51.0


  parent reply	other threads:[~2026-02-14  1:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260214010245.3671907-1-sashal@kernel.org>
2026-02-14  0:58 ` [PATCH AUTOSEL 6.19] hwmon: (asus-ec-sensors) add Pro WS TRX50-SAGE WIFI A Sasha Levin
2026-02-14  0:58 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (nct6683) Add customer ID for ASRock Z590 Taichi Sasha Levin
2026-02-14  0:59 ` [PATCH AUTOSEL 6.19-6.1] hwmon: (f71882fg) Add F81968 support Sasha Levin
2026-02-14  0:59 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (emc2305) Fix a resource leak in emc2305_of_parse_pwm_child Sasha Levin
2026-02-14  0:59 ` Sasha Levin [this message]
2026-02-14  0:59 ` [PATCH AUTOSEL 6.19-6.18] hwmon: (nct7363) Fix a resource leak in nct7363_present_pwm_fanin Sasha Levin
2026-02-14  1:00 ` [PATCH AUTOSEL 6.19-6.12] hwmon: (dell-smm) Add support for Dell OptiPlex 7080 Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260214010245.3671907-96-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=patches@lists.linux.dev \
    --cc=pauk.denis@gmail.com \
    --cc=shoes2ga@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox