From: Andrew Davis <afd@ti.com>
To: Guenter Roeck <linux@roeck-us.net>,
Chiang Brian <chiang.brian@inventec.com>,
Erick Karanja <karanja99erick@gmail.com>,
"Grant Peltier" <grantpeltier93@gmail.com>,
Jeff Lin <jefflin994697@gmail.com>,
Cherrence Sarip <cherrence.sarip@analog.com>,
Kim Seer Paller <kimseer.paller@analog.com>,
Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Cc: <linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Andrew Davis" <afd@ti.com>
Subject: [PATCH v2 09/11] hwmon: (pmbus/fsp-3y) Remove use of i2c_match_id()
Date: Fri, 6 Mar 2026 11:16:50 -0600 [thread overview]
Message-ID: <20260306171652.951274-10-afd@ti.com> (raw)
In-Reply-To: <20260306171652.951274-1-afd@ti.com>
The function i2c_match_id() is used to fetch the matching ID from
the i2c_device_id table. This can be done instead with
i2c_client_get_device_id() which doesn't need the i2c_device_id
passed in so we do not need to have that forward declared, allowing
us to move the i2c_device_id table down to its more natural spot
with the other module info.
Signed-off-by: Andrew Davis <afd@ti.com>
---
drivers/hwmon/pmbus/fsp-3y.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/hwmon/pmbus/fsp-3y.c b/drivers/hwmon/pmbus/fsp-3y.c
index a4dc09e2ef75a..cad4d23300036 100644
--- a/drivers/hwmon/pmbus/fsp-3y.c
+++ b/drivers/hwmon/pmbus/fsp-3y.c
@@ -222,12 +222,6 @@ static int fsp3y_detect(struct i2c_client *client)
return -ENODEV;
}
-static const struct i2c_device_id fsp3y_id[] = {
- {"ym2151e", ym2151e},
- {"yh5151e", yh5151e},
- { }
-};
-
static int fsp3y_probe(struct i2c_client *client)
{
struct fsp3y_data *data;
@@ -242,7 +236,7 @@ static int fsp3y_probe(struct i2c_client *client)
if (data->chip < 0)
return data->chip;
- id = i2c_match_id(fsp3y_id, client);
+ id = i2c_client_get_device_id(client);
if (data->chip != id->driver_data)
dev_warn(&client->dev, "Device mismatch: Configured %s (%d), detected %d\n",
id->name, (int)id->driver_data, data->chip);
@@ -276,6 +270,11 @@ static int fsp3y_probe(struct i2c_client *client)
return pmbus_do_probe(client, &data->info);
}
+static const struct i2c_device_id fsp3y_id[] = {
+ {"ym2151e", ym2151e},
+ {"yh5151e", yh5151e},
+ { }
+};
MODULE_DEVICE_TABLE(i2c, fsp3y_id);
static struct i2c_driver fsp3y_driver = {
--
2.39.2
next prev parent reply other threads:[~2026-03-06 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-06 17:16 [PATCH v2 00/11] Remove use of i2c_match_id in PMBUS Andrew Davis
2026-03-06 17:16 ` [PATCH v2 01/11] hwmon: (pmbus/bel-pfe) Remove use of i2c_match_id() Andrew Davis
2026-03-06 17:16 ` [PATCH v2 02/11] hwmon: (pmbus/ibm-cffps) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 03/11] hwmon: (pmbus/isl68137) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 04/11] hwmon: (pmbus/max20730) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 05/11] hwmon: (pmbus/max34440) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 06/11] hwmon: (pmbus) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 07/11] hwmon: (pmbus/q54sj108a2) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 08/11] hwmon: (pmbus/tps53679) " Andrew Davis
2026-03-06 17:16 ` Andrew Davis [this message]
2026-03-06 17:16 ` [PATCH v2 10/11] hwmon: (pmbus/ltc2978) " Andrew Davis
2026-03-06 18:10 ` Guenter Roeck
2026-03-06 18:30 ` Andrew Davis
2026-03-06 17:16 ` [PATCH v2 11/11] hwmon: (pmbus/max16601) " Andrew Davis
2026-03-06 18:13 ` [PATCH v2 00/11] Remove use of i2c_match_id in PMBUS Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260306171652.951274-10-afd@ti.com \
--to=afd@ti.com \
--cc=alexisczezar.torreno@analog.com \
--cc=cherrence.sarip@analog.com \
--cc=chiang.brian@inventec.com \
--cc=grantpeltier93@gmail.com \
--cc=jefflin994697@gmail.com \
--cc=karanja99erick@gmail.com \
--cc=kimseer.paller@analog.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox