Re: [PATCH v2 00/11] Remove use of i2c_match_id in PMBUS

Guenter Roeck
2026-03-06T18:13:20Z

On 3/6/26 09:16, Andrew Davis wrote:
> Hello all,
>
> Much like we already have done for HWMON top level drivers,
> we are removing the i2c_match_id() function from all hwmon/pmbus/
> drivers now. Using i2c_get_match_data() can simplify code and has
> some other benefits described in the patches.
>
> I don't have most of this hardware, so testing is very welcome :)
>
It looks safe to me, so I'll apply the series. There is a potential
pre-existing problem in the ltc2978 driver, but that is really unrelated
to this series, and it is better to fix that separately anyway.

Thanks,
Guenter

> Thanks,
> Andrew
>
> Changes for v2:
> - Moved enum value [2/11] to prevent 0 from matching valid device
> - Trimmed all commit messages to only patch relevant info
>
> Andrew Davis (11):
> hwmon: (pmbus/bel-pfe) Remove use of i2c_match_id()
> hwmon: (pmbus/ibm-cffps) Remove use of i2c_match_id()
> hwmon: (pmbus/isl68137) Remove use of i2c_match_id()
> hwmon: (pmbus/max20730) Remove use of i2c_match_id()
> hwmon: (pmbus/max34440) Remove use of i2c_match_id()
> hwmon: (pmbus) Remove use of i2c_match_id()
> hwmon: (pmbus/q54sj108a2) Remove use of i2c_match_id()
> hwmon: (pmbus/tps53679) Remove use of i2c_match_id()
> hwmon: (pmbus/fsp-3y) Remove use of i2c_match_id()
> hwmon: (pmbus/ltc2978) Remove use of i2c_match_id()
> hwmon: (pmbus/max16601) Remove use of i2c_match_id()
>
> drivers/hwmon/pmbus/bel-pfe.c | 5 +----
> drivers/hwmon/pmbus/fsp-3y.c | 13 ++++++-------
> drivers/hwmon/pmbus/ibm-cffps.c | 16 +++-------------
> drivers/hwmon/pmbus/isl68137.c | 4 +---
> drivers/hwmon/pmbus/ltc2978.c | 2 +-
> drivers/hwmon/pmbus/max16601.c | 2 +-
> drivers/hwmon/pmbus/max20730.c | 5 +----
> drivers/hwmon/pmbus/max34440.c | 4 +---
> drivers/hwmon/pmbus/pmbus.c | 4 +---
> drivers/hwmon/pmbus/q54sj108a2.c | 5 +----
> drivers/hwmon/pmbus/tps53679.c | 5 +----
> 11 files changed, 18 insertions(+), 47 deletions(-)
>