public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Guenter Roeck <linux@roeck-us.net>,
	Chiang Brian <chiang.brian@inventec.com>,
	Erick Karanja <karanja99erick@gmail.com>,
	"Grant Peltier" <grantpeltier93@gmail.com>,
	Jeff Lin <jefflin994697@gmail.com>,
	Cherrence Sarip <cherrence.sarip@analog.com>,
	Kim Seer Paller <kimseer.paller@analog.com>,
	Alexis Czezar Torreno <alexisczezar.torreno@analog.com>
Cc: <linux-hwmon@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Andrew Davis" <afd@ti.com>
Subject: [PATCH v2 06/11] hwmon: (pmbus) Remove use of i2c_match_id()
Date: Fri, 6 Mar 2026 11:16:47 -0600	[thread overview]
Message-ID: <20260306171652.951274-7-afd@ti.com> (raw)
In-Reply-To: <20260306171652.951274-1-afd@ti.com>

The function i2c_match_id() is used to fetch the matching ID from
the i2c_device_id table. This is often used to then retrieve the
matching driver_data. This can be done in one step with the helper
i2c_get_match_data().

This helper has another benefit:
 * It doesn't need the i2c_device_id passed in so we do not need
   to have that forward declared, allowing us to remove that.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 drivers/hwmon/pmbus/pmbus.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/hwmon/pmbus/pmbus.c b/drivers/hwmon/pmbus/pmbus.c
index 920cd5408141a..d1844c7a51eef 100644
--- a/drivers/hwmon/pmbus/pmbus.c
+++ b/drivers/hwmon/pmbus/pmbus.c
@@ -20,8 +20,6 @@ struct pmbus_device_info {
 	u32 flags;
 };
 
-static const struct i2c_device_id pmbus_id[];
-
 /*
  * Find sensor groups and status registers on each page.
  */
@@ -174,7 +172,7 @@ static int pmbus_probe(struct i2c_client *client)
 	if (!info)
 		return -ENOMEM;
 
-	device_info = (struct pmbus_device_info *)i2c_match_id(pmbus_id, client)->driver_data;
+	device_info = (struct pmbus_device_info *)i2c_get_match_data(client);
 	if (device_info->flags) {
 		pdata = devm_kzalloc(dev, sizeof(struct pmbus_platform_data),
 				     GFP_KERNEL);
-- 
2.39.2


  parent reply	other threads:[~2026-03-06 17:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 17:16 [PATCH v2 00/11] Remove use of i2c_match_id in PMBUS Andrew Davis
2026-03-06 17:16 ` [PATCH v2 01/11] hwmon: (pmbus/bel-pfe) Remove use of i2c_match_id() Andrew Davis
2026-03-06 17:16 ` [PATCH v2 02/11] hwmon: (pmbus/ibm-cffps) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 03/11] hwmon: (pmbus/isl68137) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 04/11] hwmon: (pmbus/max20730) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 05/11] hwmon: (pmbus/max34440) " Andrew Davis
2026-03-06 17:16 ` Andrew Davis [this message]
2026-03-06 17:16 ` [PATCH v2 07/11] hwmon: (pmbus/q54sj108a2) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 08/11] hwmon: (pmbus/tps53679) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 09/11] hwmon: (pmbus/fsp-3y) " Andrew Davis
2026-03-06 17:16 ` [PATCH v2 10/11] hwmon: (pmbus/ltc2978) " Andrew Davis
2026-03-06 18:10   ` Guenter Roeck
2026-03-06 18:30     ` Andrew Davis
2026-03-06 17:16 ` [PATCH v2 11/11] hwmon: (pmbus/max16601) " Andrew Davis
2026-03-06 18:13 ` [PATCH v2 00/11] Remove use of i2c_match_id in PMBUS Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306171652.951274-7-afd@ti.com \
    --to=afd@ti.com \
    --cc=alexisczezar.torreno@analog.com \
    --cc=cherrence.sarip@analog.com \
    --cc=chiang.brian@inventec.com \
    --cc=grantpeltier93@gmail.com \
    --cc=jefflin994697@gmail.com \
    --cc=karanja99erick@gmail.com \
    --cc=kimseer.paller@analog.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox