Re: [PATCH v2 12/13] hwmon: spd5118: Add I3C support

sashiko-bot
2026-04-09T12:36:49Z

Sashiko AI review found 1 potential issue(s):
- [Low] Unmet Kconfig dependencies and build failures when CONFIG_I3C=m and CONFIG_I2C=n.
--

commit f34d2926473bc2c3d9a64dd532178bd0f77d003d
Author: Akhil R <akhilrajeev@nvidia.com>

hwmon: spd5118: Add I3C support

This commit adds I3C support to the SPD5118 driver, introducing a regmap
config and an I3C probe function, matching via OF.

> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index fb847ab40ab4f..d1c660d2e2c10 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -2298,12 +2298,15 @@ config SENSORS_INA3221
>
> config SENSORS_SPD5118
> tristate "SPD5118 Compliant Temperature Sensors"
> - depends on I2C
> + depends on I3C_OR_I2C
> select REGMAP_I2C

Will this cause an unmet dependency warning? If CONFIG_I3C=m and
CONFIG_I2C=n, the dependency on I3C_OR_I2C is satisfied, but REGMAP_I2C
is unconditionally selected without its dependency on I2C being met.

> + select REGMAP_I3C if I3C
> help

[ ... ]

> diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c
> index 8fdde35e68cd3..db66028d2f590 100644
> --- a/drivers/hwmon/spd5118.c
> +++ b/drivers/hwmon/spd5118.c

[ ... ]

> @@ -701,7 +723,39 @@ static struct i2c_driver spd5118_i2c_driver = {
> .address_list = IS_ENABLED(CONFIG_SENSORS_SPD5118_DETECT) ? normal_i2c : NULL,
> };
>
> -module_i2c_driver(spd5118_i2c_driver);
> +/* I3C */

[ ... ]

> +static struct i3c_driver spd5118_i3c_driver = {
> + .driver = {
> + .name = "spd5118_i3c",
> + .of_match_table = spd5118_of_ids,
> + .pm = pm_sleep_ptr(&spd5118_pm_ops),
> + },
> + .probe = spd5118_i3c_probe,
> +};
> +
> +module_i3c_i2c_driver(spd5118_i3c_driver, &spd5118_i2c_driver);

Can this lead to a build failure when CONFIG_I2C is disabled?

The module_i3c_i2c_driver() macro expands to i3c_i2c_driver_register(), which
unconditionally calls i2c_add_driver(). However, when CONFIG_I2C=n,
i2c_add_driver() isn't defined in linux/i2c.h as it lacks a fallback stub,
which could result in an implicit declaration error during compilation.

--
Sashiko AI review · https://sashiko.dev/#/patchset/20260409105747.48158-1-akhilrajeev@nvidia.com?part=12