Re: [PATCH v2 01/13] dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA

sashiko-bot
2026-04-09T11:14:26Z

Sashiko AI review found 1 potential issue(s):
- [Medium] The `minimum: 0x1` constraint prevents setting the bitmap to 0, which is required to indicate that a device does not support any static assignment methods.
--

commit 5ee586d2db5968f1eb0c491d74258e50f54fd66a
Author: Akhil R <akhilrajeev@nvidia.com>

dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA

This commit adds the mipi-i3c-static-method property to specify the discovery
methods supported by an I3C device during bus initialization. The property is
a bitmap that defaults to 1 (SETDASA) if not present.

Link: https://www.mipi.org/mipi-disco-for-i3c-download

> diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation/devicetree/bindings/i3c/i3c.yaml
> --- a/Documentation/devicetree/bindings/i3c/i3c.yaml
> +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml
[ ... ]
> @@ -147,6 +149,26 @@ patternProperties:
> through SETDASA. If static address is not present, this address is assigned
> through SETNEWDA after assigning a temporary address via ENTDAA.
>
> + mipi-i3c-static-method:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0x1

Does this minimum constraint prevent setting the bitmap to 0?

The property description states that a bit value of 0 indicates a lack of
support for a given method. Because the schema defaults to 1 (SETDASA) when
the property is absent, an I3C target that has a static address but does
not support any static methods must explicitly set this to 0 to override
the default. The current constraint appears to reject a value of 0, which
would cause validation to fail for such configurations.

> + maximum: 0xff
> + default: 1
> + description: |
> + Bitmap describing which methods of Dynamic Address Assignment from a
> + static address are supported by this I3C Target. A bit value of 1
> + indicates support for that method, and 0 indicates lack of support.

--
Sashiko AI review · https://sashiko.dev/#/patchset/20260409105747.48158-1-akhilrajeev@nvidia.com?part=1