Re: [PATCH v2 12/13] hwmon: spd5118: Add I3C support

Guenter Roeck
2026-04-09T14:15:09Z

On 4/9/26 05:36, sashiko-bot@kernel.org wrote:
> Sashiko AI review found 1 potential issue(s):
> - [Low] Unmet Kconfig dependencies and build failures when CONFIG_I3C=m and CONFIG_I2C=n.
> --
>
> commit f34d2926473bc2c3d9a64dd532178bd0f77d003d
> Author: Akhil R <akhilrajeev@nvidia.com>
>
> hwmon: spd5118: Add I3C support
>
> This commit adds I3C support to the SPD5118 driver, introducing a regmap
> config and an I3C probe function, matching via OF.
>
>> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
>> index fb847ab40ab4f..d1c660d2e2c10 100644
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -2298,12 +2298,15 @@ config SENSORS_INA3221
>>
>> config SENSORS_SPD5118
>> tristate "SPD5118 Compliant Temperature Sensors"
>> - depends on I2C
>> + depends on I3C_OR_I2C
>> select REGMAP_I2C
>
> Will this cause an unmet dependency warning? If CONFIG_I3C=m and
> CONFIG_I2C=n, the dependency on I3C_OR_I2C is satisfied, but REGMAP_I2C
> is unconditionally selected without its dependency on I2C being met.
>

That can't happen since I3C selects I2C, so ignore this feedback.

Guenter