Re: [PATCH v1 2/2] thermal: hwmon: Use extra_groups for adding temperature attributes

[sashiko-bot@kernel.org]

Sashiko AI review found 1 potential issue(s):
- [Low] Incomplete refactoring leaves unused fields in `struct thermal_hwmon_temp`.
--

commit 31b1d3d5cb622738ced37ad0ce85eba8a7a4b533
Author: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

thermal: hwmon: Use extra_groups for adding temperature attributes

This commit simplifies the thermal hwmon device registration by passing an
attribute group directly via the extra_groups argument instead of adding
each sysfs attribute individually.

> diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> index 46c40c0852804..49d06cf27bd87 100644
> --- a/drivers/thermal/thermal_hwmon.c
> +++ b/drivers/thermal/thermal_hwmon.c

[ ... ]

>  /* one temperature input for each thermal zone */
>  struct thermal_hwmon_temp {
>  	struct list_head hwmon_node;
>  	struct thermal_zone_device *tz;
> -	struct thermal_hwmon_attr temp_input;	/* hwmon sys attr */
> -	struct thermal_hwmon_attr temp_crit;	/* hwmon sys attr */
> +	struct device_attribute temp_input;	/* hwmon sys attr */
> +	struct device_attribute temp_crit;	/* hwmon sys attr */
>  };

Are temp_input and temp_crit still needed in struct thermal_hwmon_temp?

Now that the attributes are registered via the static thermal_hwmon_group
using DEVICE_ATTR_RO, it looks like these fields are no longer initialized
or used anywhere in the updated code.

Could they be removed entirely to avoid keeping dead fields and to save memory
in the dynamically allocated struct thermal_hwmon_device?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/5100596.31r3eYUQgx@rafael.j.wysocki?part=2