Re: [PATCH v11 1/3] dt-bindings: hwmon: Document the LTC4283 Swap Controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The `dependencies` block unnecessarily requires `adi,pgio4-func` to be explicitly present when external fault properties are enabled, artificially invalidating its default value.
- [Low] Missing `multipleOf` constraint for `adi,current-limit-sense-microvolt` to enforce step size.
--

commit 06a7fb3172f7064acd0275a6c3a0ec99c7ab6d79
Author: Nuno Sá <nuno.sa@analog.com>

dt-bindings: hwmon: Document the LTC4283 Swap Controller

This commit introduces the device tree bindings for the LTC4283 negative
voltage hot swap controller. It defines properties for sense resistor
value, current limits, fault handling, and GPIO functionality on the
PGIO and ADIO pins.

> diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc4283.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc4283.yaml
> new file mode 100644
> index 000000000000..05e2132ad4d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc4283.yaml
[ ... ]
> +  adi,current-limit-sense-microvolt:
> +    description:
> +      The current limit sense voltage of the chip is adjustable between
> +      15mV and 30mV in 1mV steps. This effectively limits the current
> +      on the load.
> +    minimum: 15000
> +    maximum: 30000
> +    default: 15000

Since the description notes that the value is adjustable in 1mV steps and
the unit here is microvolts, should this property include a multipleOf: 1000
constraint to enforce the step size during schema validation?

[ ... ]
> +dependencies:
> +  adi,gpio-on-adio1:
> +    - gpio-controller
> +    - '#gpio-cells'
> +  adi,gpio-on-adio2:
> +    - gpio-controller
> +    - '#gpio-cells'
> +  adi,gpio-on-adio3:
> +    - gpio-controller
> +    - '#gpio-cells'
> +  adi,gpio-on-adio4:
> +    - gpio-controller
> +    - '#gpio-cells'
> +  adi,external-fault-retry-enable:
> +    - adi,pgio4-func
> +  adi,external-fault-fet-off-enable:
> +    - adi,pgio4-func

Does this dependency unnecessarily require adi,pgio4-func to be explicitly
defined in the device tree?

Since adi,pgio4-func has a default value of "inverted_external_fault" defined
earlier in the schema, a device tree omitting it should still conceptually
support the external fault features. Enforcing its presence here might force
users to redundantly define adi,pgio4-func to pass schema validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260429-ltc4283-support-v11-0-27ccde619dad@analog.com?part=1