Re: [PATCH v2 3/3] hwmon: (pmbus) add support for Delta E50SN12051

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unnecessary memory allocation using devm_kmemdup for a static structure.
--

commit e0fb0b22fc908f166717510eea0ebcb85704a919
Author: Colin Huang <u8813345@gmail.com>

hwmon: (pmbus) add support for Delta E50SN12051

This commit introduces a new PMBus driver for the Delta E50SN12051 600W
Non-isolated 1/8th Brick DCDC Power Modules.

> diff --git a/drivers/hwmon/pmbus/e50sn12051.c b/drivers/hwmon/pmbus/e50sn12051.c
> new file mode 100644
> index 000000000000..3d61db949afb
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/e50sn12051.c
[ ... ]
> +static int e50sn12051_probe(struct i2c_client *client)
> +{
> +	struct pmbus_driver_info *info;
> +
> +	info = devm_kmemdup(&client->dev, &e50sn12051_info, sizeof(*info),
> +			    GFP_KERNEL);
> +	if (!info)
> +		return -ENOMEM;
> +
> +	return pmbus_do_probe(client, info);
> +}

Is it necessary to duplicate the e50sn12051_info structure using
devm_kmemdup() here?

The e50sn12051_info structure is statically defined and fully populated at
compile time. Looking at the PMBus core, it only modifies the
pmbus_driver_info structure if the PMBUS_USE_COEFFICIENTS_CMD flag is set,
which is not the case for this driver.

Could this be simplified to pass &e50sn12051_info directly to
pmbus_do_probe() to avoid the extra memory allocation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260430-add-e50sn12051-v2-0-d76fe42482ab@gmail.com?part=3