Re: [PATCH v4 1/2] dt-bindings: hwmon: Add Eswin EIC7700 PVT sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The 'label' property is required and restricted to an enum, misusing it for hardware instance identification.
- [Medium] The '#thermal-sensor-cells' property is defined but omitted from the 'required' list.
--

commit 5a5ed34d17ea4e88cd80b5a8e96e21dcc65e9f11
Author: Huan He <hehuan1@eswincomputing.com>

dt-bindings: hwmon: Add Eswin EIC7700 PVT sensor

This commit adds the device tree binding documentation for the Eswin
EIC7700 Process, Voltage and Temperature sensor. The SoC integrates two
PVT instances for monitoring the main SoC and DDR power domains.

> diff --git a/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml b/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml
> new file mode 100644
> index 0000000000000..ba89b829ee947
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/eswin,eic7700-pvt.yaml

[ ... ]

> +  interrupts:
> +    maxItems: 1
> +
> +  label:
> +    enum:
> +      - pvt0
> +      - pvt1

Is it appropriate to restrict the standard label property to a strict enum
and require it? 

The devicetree specification generally defines label as an optional,
human-readable string. Should the hardware instances be differentiated by
their reg addresses, aliases, or dedicated properties instead of imposing
a strict enum on a standard free-form string?

> +
> +  resets:
> +    maxItems: 1
> +
> +  '#thermal-sensor-cells':
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - interrupts
> +  - label
> +  - resets

Should #thermal-sensor-cells be included in this required list?

Since the device acts as a thermal sensor provider, omitting its cell-count
property allows incomplete device tree nodes to silently pass schema
validation. This might lead to runtime failures or misconfigurations when
dependent thermal zones attempt to reference the sensor.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260430064107.1598-1-hehuan1@eswincomputing.com?part=1