From: Tabrez Ahmed <tabreztalks@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah@kernel.org, me@brighamcampbell.com,
Tabrez Ahmed <tabreztalks@gmail.com>
Subject: [PATCH v4 0/3] hwmon: (ads7871) Fix endianness and modernize driver
Date: Fri, 1 May 2026 07:00:40 +0530 [thread overview]
Message-ID: <20260501013044.22756-1-tabreztalks@gmail.com> (raw)
This series addresses several issues in the ads7871 driver. It fixes an
architecture-dependent endianness bug in the 16-bit register read logic,
migrates the driver to the modern hwmon_device_register_with_info() API,
and moves the SPI transfer buffer into the driver's private data structure
to ensure DMA safety.
Note: I do not have access to the physical ADS7871 hardware. This
series has been compile-tested only.
Changes in v4:
- Fixed an additional Big-Endian hazard where passing a pointer
to a 32-bit 'int' for a 1-byte SPI write transmitted the wrong command
byte. Refactored to use a dedicated 'u8' transmit variable.
Changes in v3:
- Added Patch 1 to fix the pre-existing endianness bug in 16-bit reads,
originally flagged by Sashiko AI.
- Fixed multiple formatting and alignment issues caught by checkpatch
--strict, as requested by Guenter Roeck.
- Added "While at it, fix checkpatch violations" to Patch 2 commit message.
Changes in v2:
- Dropped custom mutex in favor of native hwmon core serialization.
- Split API migration and DMA fix into separate, logical patches.
- Corrected output scaling and sign extension to meet hwmon ABI.
Tabrez Ahmed (3):
hwmon: (ads7871) Fix endianness bug in 16-bit register reads
hwmon: (ads7871) Convert to hwmon_device_register_with_info
hwmon: (ads7871) Use DMA-safe buffer for SPI writes
drivers/hwmon/ads7871.c | 121 +++++++++++++++++++++++-----------------
1 file changed, 71 insertions(+), 50 deletions(-)
--
2.43.0
next reply other threads:[~2026-05-01 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 1:30 Tabrez Ahmed [this message]
2026-05-01 1:30 ` [PATCH v4 1/3] hwmon: (ads7871) Fix endianness bug in 16-bit register reads Tabrez Ahmed
2026-05-01 1:46 ` sashiko-bot
2026-05-01 1:30 ` [PATCH v4 2/3] hwmon: (ads7871) Convert to hwmon_device_register_with_info Tabrez Ahmed
2026-05-01 1:30 ` [PATCH v4 3/3] hwmon: (ads7871) Use DMA-safe buffer for SPI writes Tabrez Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260501013044.22756-1-tabreztalks@gmail.com \
--to=tabreztalks@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=me@brighamcampbell.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox