From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F4FE40DFC5 for ; Fri, 1 May 2026 01:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777599998; cv=none; b=n1RgLpLhrllftvLoDOzYQDCml+rZmYFOoPWgEdH1zuw7/rhhLjYWfuwKVyMQOdGqhzDhpnOFs4Lv/hmxWYBySULuHy/kE8xHdqqFcXo3OICb65sEbUhLhQ/yqQwUtilDckfGYMP/bP/Nn9d7Sn1kLiCZXn/Hl+pVY4ArEF1hZUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777599998; c=relaxed/simple; bh=If8Fdw6Hpk+6Ln1L/DdDqHqiRynd6T2oMeAzbSYKzhY=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=MAmMJgvW0VuBYIPB/eIVkWPJyO6d0JgIpK/u3spZl2GpbBh+I1ZxJaVlEBaDNdCZNEIBUl3/iC7L1hyA9JjBVTGYaw600JihSu/1WimzeCQ32ZdwTf48MYUuYwQPrzD8fyVIWNgtg6HU3qLhsLKX6dbkzqyrlO4oxwqyh0WdsAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kZ1IAxy3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kZ1IAxy3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3155C2BCB3; Fri, 1 May 2026 01:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777599998; bh=If8Fdw6Hpk+6Ln1L/DdDqHqiRynd6T2oMeAzbSYKzhY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date:From; b=kZ1IAxy3YZ9UszRPaJu/5H7IaKkksTpeyh/mwPJpT9jB7pPBBE4PtZf52mLPl8FdL AITQkahs+/Fv6zm6IkLbQsLm/8eykVkPTD3iIcjjyQq/VjFW/PwV+JlQI037NdQYrC b1vn9OeofmZV11z0ELawukRr0XjPN7pQ+pTOVFvdoviDuUfNL34g2aVHv+F/k+2tYU 1YiEipR7WRSzgZf+Styq4PNoeRbYu9zGCkxCMRcA2Rpa02NIPdQ+XjAqWRhJY4E+Fo pdBKMlFZYEfZyGcyB8mSPfEQTNFpRcFqSpzbZvIH1Pljhi/Z4yhvwefFn7Pavc5CTt xtPE8SXWuT0aA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 1/3] hwmon: (ads7871) Fix endianness bug in 16-bit register reads Reply-To: sashiko@lists.linux.dev To: "Tabrez Ahmed" Cc: linux-hwmon@vger.kernel.org In-Reply-To: <20260501013044.22756-2-tabreztalks@gmail.com> References: <20260501013044.22756-2-tabreztalks@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 01 May 2026 01:46:37 +0000 Message-Id: <20260501014637.F3155C2BCB3@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-hwmon@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The patch includes the architecture-specific `` in= stead of the generic ``. -- commit f2dcf018978363b0b13a49ceee94284796f154fb Author: Tabrez Ahmed hwmon: (ads7871) Fix endianness bug in 16-bit register reads This commit replaces spi_w8r16() with a manual spi_write_then_read() into a byte array to address an endianness bug. The 16-bit value is then safely reconstructed using get_unaligned_le16(). Closes: https://sashiko.dev/#/patchset/20260418034601.90226-1-tabreztalks@g= mail.com > diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c > index 9bfdf9e6bcd77..15104d9b2b733 100644 > --- a/drivers/hwmon/ads7871.c > +++ b/drivers/hwmon/ads7871.c > @@ -59,6 +59,7 @@ > #include > #include > #include > +#include Should this use instead of the architecture-specific header? Directly including can cause build failures on platforms that no longer expose this header directly to drivers. I notice this is addressed later in the patch series in the commit "hwmon: (ads7871) Use DMA-safe buffer for SPI writes". Does this temporary inclusion break the expectation that every patch in a series must independently compile? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260501013044.2275= 6-1-tabreztalks@gmail.com?part=3D1