Re: [PATCH v13 1/3] dt-bindings: hwmon: Document the LTC4283 Swap Controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `dependencies` block forces `adi,pgio4-func` to be explicitly defined when external fault properties are used, breaking its default value semantics.
--

commit 95d75c53b856792667507b1a119fd7e090fe8173
Author: Nuno Sá <nuno.sa@analog.com>

dt-bindings: hwmon: Document the LTC4283 Swap Controller

This commit introduces device tree binding documentation for the LTC4283
negative voltage hot swap controller. It also updates the MAINTAINERS file
with the new binding document.

> diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc4283.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc4283.yaml
> new file mode 100644
> index 000000000000..05e2132ad4d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc4283.yaml
> @@ -0,0 +1,272 @@

[ ... ]

> +  adi,pgio4-func:
> +    description: Configures the function of the PGIO4 pin.
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [inverted_external_fault, external_fault, gpio]
> +    default: inverted_external_fault

[ ... ]

> +dependencies:

[ ... ]

> +  adi,external-fault-retry-enable:
> +    - adi,pgio4-func
> +  adi,external-fault-fet-off-enable:
> +    - adi,pgio4-func

Does this dependencies block cause a regression for device trees that rely on
the default value of adi,pgio4-func?

Because adi,pgio4-func defines a default value of "inverted_external_fault"
above, omitting it from a node is perfectly valid. However, standard JSON
schema dependencies check for the literal presence of the key in the instance.

If a device tree defines adi,external-fault-retry-enable but omits
adi,pgio4-func to rely on the default value, schema validation will fail.

Since the allOf block already rejects conflicting configurations (such as when
adi,pgio4-func is set to "gpio"), could these dependency requirements be
removed to allow device trees to safely use the default value?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260502-ltc4283-support-v13-0-1c206542e652@analog.com?part=1