Re: [PATCH] hwmon: (tmp102) Change mode to read label property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Incomplete transition to firmware-agnostic API due to remaining `of_match_ptr()` usage.
- [Low] Missing inclusion of `<linux/property.h>` for `device_property_read_string()`.
--

commit 1666c25db837ad9f0af1e26c9adc185e78ab62e5
Author: Flaviu Nistor <flaviu.nistor@gmail.com>

hwmon: (tmp102) Change mode to read label property

This commit replaces the Device Tree specific of_property_read_string()
with the firmware-agnostic device_property_read_string() in the probe
function. This is intended to improve driver compatibility beyond just
Device Tree.

>     Replace of_property_read_string() with the preferred
>     device_property_read_string() in the probe function to
>     read the device label property, improving the driver
>     compatibility since this method is not limited to
>     Device Tree only.

If the goal is to improve compatibility beyond Device Tree, should the
driver also drop the use of of_match_ptr() around the match table?

When the kernel is configured without CONFIG_OF (such as on ACPI-only
systems leveraging PRP0001 for DT-style matching), of_match_ptr() evaluates
to NULL.

This drops the match table entirely and prevents the driver from binding,
which seems to contradict the intent of this patch.

> diff --git a/drivers/hwmon/tmp102.c b/drivers/hwmon/tmp102.c
> index 3aa1a3fbeaa92..a89cc49798f54 100644
> --- a/drivers/hwmon/tmp102.c
> +++ b/drivers/hwmon/tmp102.c
> @@ -313,7 +313,7 @@ static int tmp102_probe(struct i2c_client *client)
>  	if (!tmp102)
>  		return -ENOMEM;
>  
> -	of_property_read_string(dev->of_node, "label", &tmp102->label);
> +	device_property_read_string(dev, "label", &tmp102->label);

Does this code require an explicit inclusion of <linux/property.h>?

While it may currently compile due to implicit transitive includes, relying
on them is fragile and could cause build regressions if those headers are
refactored in the future.

>  
>  	i2c_set_clientdata(client, tmp102);
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260509112417.51164-1-flaviu.nistor@gmail.com?part=1