Re: [PATCH 3/5] hwmon: scmi-hwmon: Log number of sensors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The log message incorrectly reports the number of initialized sensors instead of discovered sensors.
- [Low] The format specifier `%d` is used to log an unsigned 16-bit integer.
--

commit 7a34e84c653506754b307b335485bcabd49e81df
Author: Alex Tran <alex.tran@oss.qualcomm.com>

hwmon: scmi-hwmon: Log number of sensors

This commit adds a log message to report the number of sensors during probe,
making it easier to confirm the firmware exposed the expected resources.

> diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
> index eec223d174c07..6f1b0559d5c28 100644
> --- a/drivers/hwmon/scmi-hwmon.c
> +++ b/drivers/hwmon/scmi-hwmon.c
> @@ -362,6 +362,7 @@ static int scmi_hwmon_probe(struct scmi_device *sdev)
>  		}
>  	}
>  
> +	dev_info(dev, "Initialized %d sensors\n", nr_sensors);

The nr_sensors variable holds the total number of sensors discovered from
the firmware, but the driver filters these and only initializes specific
supported hwmon types like TEMPERATURE_C and VOLTAGE. Should this message
say "Discovered" instead, or perhaps use the count of actually initialized
sensors?

This isn't a bug, but since nr_sensors is a u16, should it use the %u
format specifier instead of %d?

>  	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260513-scmi-client-probe-log-v1-0-00b47b1be009@oss.qualcomm.com?part=3